use a readable selector instead

ashokaditya · ashokaditya · commit 66ea93868e98 · 2021-08-30T12:55:09.000+02:00
review changes
diff --git a/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts b/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts
@@ -39,7 +39,7 @@ import {
   getIsOnEndpointDetailsActivityLog,
   getMetadataTransformStats,
   isMetadataTransformStatsLoading,
-  getActivityLogUninitialized,
+  getActivityLogIsUninitializedOrHasSubsequentAPIError,
 } from './selectors';
 import {
   AgentIdsPendingActions,
@@ -127,9 +127,7 @@ export const endpointMiddlewareFactory: ImmutableMiddlewareFactory<EndpointState
       action.type === 'userChangedUrl' &&
       hasSelectedEndpoint(getState()) === true &&
       getIsOnEndpointDetailsActivityLog(getState()) &&
-      (getActivityLogUninitialized(getState()) ||
-        (!!getLastLoadedActivityLogData(getState())?.data.length &&
-          !getActivityLogError(getState())))
+      getActivityLogIsUninitializedOrHasSubsequentAPIError(getState())
     ) {
       await endpointDetailsActivityLogChangedMiddleware({ store, coreStart });
     }
diff --git a/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/selectors.ts b/x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/selectors.ts
@@ -419,6 +419,19 @@ export const getActivityLogError: (
   }
 });
 
+// returns a true if either lgo is uninitialised
+// or if it has failed an api call after having fetched a non empty log list earlier
+export const getActivityLogIsUninitializedOrHasSubsequentAPIError: (
+  state: Immutable<EndpointState>
+) => boolean = createSelector(
+  getActivityLogUninitialized,
+  getLastLoadedActivityLogData,
+  getActivityLogError,
+  (isUninitialized, lastLoadedLogData, isAPIError) => {
+    return isUninitialized || (!isAPIError && !!lastLoadedLogData?.data.length);
+  }
+);
+
 export const getIsEndpointHostIsolated = createSelector(detailsData, (details) => {
   return (details && isEndpointHostIsolated(details)) || false;
 });
