[Enterprise Search] Require security plugin in 8.0#106307
Merged
cee-chen merged 5 commits intoelastic:masterfrom Jul 20, 2021
Merged
[Enterprise Search] Require security plugin in 8.0#106307cee-chen merged 5 commits intoelastic:masterfrom
cee-chen merged 5 commits intoelastic:masterfrom
Conversation
+ update KibanaLogic to no longer need a {} fallback
cee-chen
commented
Jul 20, 2021
Contributor
Author
|
SCOTTY I was just about to post asking for a review. You're a true mind reader |
ioanatia
approved these changes
Jul 20, 2021
Remove `!`s now that security is required
- turns out I need to do a little more than just updating the requiredPlugin arr & types! - based on my understanding of our 8.0 behavior Enterprise Search will not start if x-pack security is disabled, so we should probably opt to early disable the plugin for simplicity as well
scottybollinger
approved these changes
Jul 20, 2021
Contributor
scottybollinger
left a comment
There was a problem hiding this comment.
New changes LGTM. Thanks for taking the lead on this!
legrego
approved these changes
Jul 20, 2021
Member
legrego
left a comment
There was a problem hiding this comment.
Code review only -- changes to check_access LGTM
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
I'll be QAing this in the the alpha BC1 for App Search tomorrow! 🤞 |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 21, 2021
…y-show-migrate-to-authzd-users * 'master' of github.com:elastic/kibana: (48 commits) [Canvas] Expression shape (elastic#103219) [FTR] Skips Vega tests [Sample data] Use Lens in ecommerce data (elastic#106039) [APM] Backends inventory & overview page routes (elastic#106223) [TSVB] Add more functional tests for Gauge and TopN (elastic#105361) Add toggle to enable/disable rule install from SOs (elastic#106189) Improve unit test coverage of FS API calls (elastic#106242) Remove recursive plugin status in meta field (elastic#106286) [Ingest pipelines] add community id processor (elastic#103863) [XY axis] Fixes the values inside bar charts (elastic#106198) [data.search] Set default expiration to 1m if search sessions are disabled (elastic#105329) set the doc title when navigating to reporting and unset when navigating away (elastic#106253) [Lens] Display legend inside chart (elastic#105571) [RAC] [TGrid] Migrate the TGrid's rendering to `EuiDataGrid` (elastic#106199) [Security Solutions] Removes the elastic legacy client from lists and security_solution plugins (elastic#106130) [Enterprise Search] Require security plugin in 8.0 (elastic#106307) [DOCS] Updates screenshots in Dev Tools docs (elastic#105859) [DOCS] Updates text and screenshots in tags doc (elastic#105853) [Alerting] Allow rule types to extract/inject saved object references on rule CRU (elastic#101896) Jest and Storybook fixes (elastic#104991) ... # Conflicts: # x-pack/plugins/reporting/public/plugin.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per @ioanatia's 8.0 work, Enterprise Search will now require x-pack security to be enabled going forward. As such we should also update our Kibana plugin to require the security plugin.
This should NOT be backported to 7.x.
Release note
Enterprise Search now requires x-pack security to be enabled.
QA
Checklist