Skip to content

Jest and Storybook fixes#104991

Merged
smith merged 18 commits intoelastic:masterfrom
smith:nls/test-fixes
Jul 20, 2021
Merged

Jest and Storybook fixes#104991
smith merged 18 commits intoelastic:masterfrom
smith:nls/test-fixes

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented Jul 8, 2021

Fix some Jest and storybook problems:

  • Fix some typos
  • Add some missing Kibana React context mock values that were causing error output in Jest tests
  • Fix broken mock routing for latency chart stories
  • FIx dark mode and duplicate path in icon stories
  • Add story for schema confirm modal
  • Fix transaction duration alert trigger story
  • Ensure all table width values are strings (which is what's allowed by EuiBasicTableColumn
  • Change ITableColumn to use only strings for width

All storybooks should now be working and there should be no errors or warnings in Jest output.

@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v7.15.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed and removed v7.14.0 labels Jul 12, 2021
@smith smith marked this pull request as ready for review July 19, 2021 14:25
@smith smith requested a review from a team July 19, 2021 14:25
field: 'groupId',
sortable: false,
width: unit * 6,
width: `${unit * 6}`,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add px at the end here too?

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jul 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/apm-ui (Team:apm)

Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smith
Copy link
Copy Markdown
Contributor Author

smith commented Jul 20, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB +32.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit 88ac1f9 into elastic:master Jul 20, 2021
@smith smith deleted the nls/test-fixes branch July 20, 2021 21:07
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 20, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 20, 2021
Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 21, 2021
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (48 commits)
  [Canvas] Expression shape (elastic#103219)
  [FTR] Skips Vega tests
  [Sample data] Use Lens in ecommerce data (elastic#106039)
  [APM] Backends inventory & overview page routes (elastic#106223)
  [TSVB] Add more functional tests for Gauge and TopN (elastic#105361)
  Add toggle to enable/disable rule install from SOs (elastic#106189)
  Improve unit test coverage of FS API calls (elastic#106242)
  Remove recursive plugin status in meta field (elastic#106286)
  [Ingest pipelines] add community id processor (elastic#103863)
  [XY axis] Fixes the values inside bar charts (elastic#106198)
  [data.search] Set default expiration to 1m if search sessions are disabled (elastic#105329)
  set the doc title when navigating to reporting and unset when navigating away (elastic#106253)
  [Lens] Display legend inside chart (elastic#105571)
  [RAC] [TGrid] Migrate the TGrid's rendering to `EuiDataGrid` (elastic#106199)
  [Security Solutions] Removes the elastic legacy client from lists and security_solution plugins (elastic#106130)
  [Enterprise Search] Require security plugin in 8.0 (elastic#106307)
  [DOCS] Updates screenshots in Dev Tools docs (elastic#105859)
  [DOCS] Updates text and screenshots in tags doc (elastic#105853)
  [Alerting] Allow rule types to extract/inject saved object references on rule CRU (elastic#101896)
  Jest and Storybook fixes (elastic#104991)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/plugin.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.15.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants