Skip to content

Remove recursive plugin status in meta field#106286

Merged
joshdover merged 1 commit intoelastic:masterfrom
joshdover:status/simplify-meta
Jul 21, 2021
Merged

Remove recursive plugin status in meta field#106286
joshdover merged 1 commit intoelastic:masterfrom
joshdover:status/simplify-meta

Conversation

@joshdover
Copy link
Copy Markdown
Contributor

@joshdover joshdover commented Jul 20, 2021 •
edited
Loading

Summary

Fixes #100202

Depending on how a plugin implements their custom status check, it's possible for our status log messages to explode in size due to how the default status summaries rollup all of their dependencies' statuses in a recursive, cascading manner. This PR changes the default status summary to only include the names of the affected dependencies, rather than their entire status check which is already available in the full status object.

Here's the change for an individual plugin's default status object:

Before

{
  "level": "unavailable",
  "summary": "[2] services are unavailable",
  "detail": "See the status page for more information",
  "meta": {
    "affectedServices": {
      "dependencyA": {
        "level": "unavailable",
        "summary": "dependencyB is unavailable",
        "meta": {
          "affectedServices": {
            "dependencyB": {
              "level": "unavailable",
              "summary": "Something isn't working"
            }
          }
        }
      },
      "dependencyB": {
        "level": "unavailable",
        "summary": "Something isn't working"
      }
    }
  }
}

After

{
  "level": "unavailable",
  "summary": "[2] services are unavailable",
  "detail": "See the status page for more information",
  "meta": {
    "affectedServices": ["dependencyA", "dependencyB"]
  }
}

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@joshdover joshdover added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Jul 20, 2021
@joshdover joshdover requested a review from a team as a code owner July 20, 2021 16:17
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 20, 2021

Pinging @elastic/kibana-core (Team:Core)

@joshdover joshdover mentioned this pull request Jul 20, 2021
Closed
@jportner
Copy link
Copy Markdown
Contributor

jportner commented Jul 20, 2021

@joshdover WDYT about backporting this to 7.14.1?

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 20, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover merged commit 78769d7 into elastic:master Jul 21, 2021
@joshdover joshdover deleted the status/simplify-meta branch July 21, 2021 11:39
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 21, 2021
@joshdover @kibanamachine
Remove recursive plugin status in meta field (elastic#106286)
80e4bfa
@kibanamachine kibanamachine mentioned this pull request Jul 21, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 21, 2021
@joshdover @kibanamachine
Remove recursive plugin status in meta field (elastic#106286)
5c03536
@kibanamachine kibanamachine mentioned this pull request Jul 21, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jul 21, 2021

💚 Backport successful

Status Branch Result
✅ 7.14
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jul 21, 2021
@kibanamachine @joshdover
Remove recursive plugin status in meta field (#106286) (#106390)
90f4764 
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Jul 21, 2021
@kibanamachine @joshdover
Remove recursive plugin status in meta field (#106286) (#106391)
411510a 
Co-authored-by: Josh Dover <1813008+joshdover@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jul 21, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into reporting/onl…
5160a33 
…y-show-migrate-to-authzd-users

* 'master' of github.com:elastic/kibana: (48 commits)
  [Canvas] Expression shape (elastic#103219)
  [FTR] Skips Vega tests
  [Sample data] Use Lens in ecommerce data (elastic#106039)
  [APM] Backends inventory & overview page routes (elastic#106223)
  [TSVB] Add more functional tests for Gauge and TopN (elastic#105361)
  Add toggle to enable/disable rule install from SOs (elastic#106189)
  Improve unit test coverage of FS API calls (elastic#106242)
  Remove recursive plugin status in meta field (elastic#106286)
  [Ingest pipelines] add community id processor (elastic#103863)
  [XY axis] Fixes the values inside bar charts (elastic#106198)
  [data.search] Set default expiration to 1m if search sessions are disabled (elastic#105329)
  set the doc title when navigating to reporting and unset when navigating away (elastic#106253)
  [Lens] Display legend inside chart (elastic#105571)
  [RAC] [TGrid] Migrate the TGrid's rendering to `EuiDataGrid` (elastic#106199)
  [Security Solutions] Removes the elastic legacy client from lists and security_solution plugins (elastic#106130)
  [Enterprise Search] Require security plugin in 8.0 (elastic#106307)
  [DOCS] Updates screenshots in Dev Tools docs (elastic#105859)
  [DOCS] Updates text and screenshots in tags doc (elastic#105853)
  [Alerting] Allow rule types to extract/inject saved object references on rule CRU (elastic#101896)
  Jest and Storybook fixes (elastic#104991)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/plugin.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.14.1 v7.15.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Status service logs huge messages, blowing up filebeat indexing

5 participants

@joshdover @elasticmachine @jportner @kibanamachine @lukeelmers