[Query] Es query/field base by lizozom · Pull Request #103177 · elastic/kibana

lizozom · 2021-06-23T20:33:19Z

Summary

Part of #51659

Introduces a new FieldBase type to allow separating es-query into a pacakge.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

elasticmachine · 2021-06-23T20:33:21Z

Pinging @elastic/kibana-app-services (Team:AppServices)

…ve-convert

…d-base

mattkime

A couple of notes but overall lgtm

src/plugins/data/common/es_query/es_query/types.ts

…d-base

mattkime

code changes look good

kibanamachine · 2021-06-30T11:15:14Z

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`data`	3268	3252	-16

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`data`	834.1KB	834.6KB	+555.0B

Unknown metric groups

API count

id	before	after	diff
`data`	3833	3818	-15

History

💚 Build #135074 succeeded d210ddb
💔 Build #134983 failed 028d7da
💚 Build #134505 succeeded 7984b50
💔 Build #134413 failed a0696b5
💔 Build #134412 failed 08a5c85

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @lizozom

* remove es query dependency on format.convert * FieldBase * fix types * types * Fix type imports * test types * fix jest * rename * docs * comment

kibanamachine · 2021-06-30T12:10:19Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…-policy-2 * 'master' of github.com:elastic/kibana: [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850) [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852) Allow zero (0) to unset unenroll_timeout field (elastic#103790) [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717) [Query] Es query/field base (elastic#103177) Remove add data button from nav (elastic#103810) Fix telemetry advanced setting style (elastic#103838) [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690) [APM] use conventional error rate color for correlations (elastic#103500) # Conflicts: # x-pack/plugins/reporting/server/lib/store/store.ts

…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (178 commits) [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028) [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850) [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852) Allow zero (0) to unset unenroll_timeout field (elastic#103790) [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717) [Query] Es query/field base (elastic#103177) Remove add data button from nav (elastic#103810) Fix telemetry advanced setting style (elastic#103838) [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690) [APM] use conventional error rate color for correlations (elastic#103500) Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171) [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663) fix too many rernders (elastic#103672) [APM] Add “Analyze Data” button (elastic#103485) [Lens] Fix value popover spacing (elastic#103081) [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926) [SECURITY] Adds security links to doc link service (elastic#102676) Update dependency @elastic/charts to v31 (elastic#102078) [Security Solution][CTI] Investigation time enrichment UI (elastic#103383) Adds ECS guide to doc links service (elastic#102246) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx

* [Query] Es query/field base (#103177) * remove es query dependency on format.convert * FieldBase * fix types * types * Fix type imports * test types * fix jest * rename * docs * comment * docs Co-authored-by: Liza Katz <lizka.k@gmail.com> Co-authored-by: Liza K <liza.katz@elastic.co>

Liza K added 2 commits June 23, 2021 23:08

remove es query dependency on format.convert

adc6234

FieldBase

f8e7e15

lizozom added v8.0.0 Team:AppServices release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 23, 2021

lizozom self-assigned this Jun 23, 2021

lizozom requested a review from a team as a code owner June 23, 2021 20:33

Merge branch 'master' of github.com:elastic/kibana into es-kuery/remo…

759a016

…ve-convert

lizozom mentioned this pull request Jun 23, 2021

[Data - Query Service] Move es-query back into a dedicated package #51659

Closed

3 tasks

Liza K added 8 commits June 23, 2021 23:47

fix types

1a2284f

Merge branch 'master' of github.com:elastic/kibana into es-kuery/remo…

9111374

…ve-convert

types

5b40ebc

Merge branch 'es-kuery/remove-convert' into es-query/field-base

435c547

Fix type imports

08a5c85

test types

a0696b5

Merge branch 'master' of github.com:elastic/kibana into es-query/fiel…

3342d1b

…d-base

fix jest

7984b50

mattkime requested changes Jun 28, 2021

View reviewed changes

src/plugins/data/common/es_query/es_query/types.ts Outdated Show resolved Hide resolved

src/plugins/data/common/es_query/es_query/types.ts Show resolved Hide resolved

Liza K added 5 commits June 29, 2021 09:18

Merge branch 'master' of github.com:elastic/kibana into es-query/fiel…

3ba52f8

…d-base

Merge branch 'master' of github.com:elastic/kibana into es-query/fiel…

d5df964

…d-base

rename

028d7da

docs

d210ddb

Merge branch 'master' of github.com:elastic/kibana into es-query/fiel…

34598e8

…d-base

lizozom requested a review from mattkime June 30, 2021 09:08

comment

ebb9a14

mattkime approved these changes Jun 30, 2021

View reviewed changes

lizozom merged commit 2bc801c into elastic:master Jun 30, 2021

kibanamachine mentioned this pull request Jun 30, 2021

[7.x] [Query] Es query/field base (#103177) #103872

Merged

spalger added the v7.15.0 label Jul 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Query] Es query/field base#103177

[Query] Es query/field base#103177
lizozom merged 17 commits intoelastic:masterfrom
lizozom:es-query/field-base

lizozom commented Jun 23, 2021

Uh oh!

elasticmachine commented Jun 23, 2021

Uh oh!

mattkime left a comment

Uh oh!

Uh oh!

Uh oh!

mattkime left a comment

Uh oh!

kibanamachine commented Jun 30, 2021

API count

Uh oh!

kibanamachine commented Jun 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

lizozom commented Jun 23, 2021

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

elasticmachine commented Jun 23, 2021

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 30, 2021

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Page load bundle

API count

History

Uh oh!

kibanamachine commented Jun 30, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants