Skip to content

Adds ECS guide to doc links service#102246

Merged
lcawl merged 2 commits intoelastic:masterfrom
lcawl:security-links
Jun 30, 2021
Merged

Adds ECS guide to doc links service#102246
lcawl merged 2 commits intoelastic:masterfrom
lcawl:security-links

Conversation

@lcawl
Copy link
Copy Markdown
Member

@lcawl lcawl commented Jun 15, 2021

Summary

This PR updates a help menu link for the Security app such that it uses the doc link service, which is easier to maintain and tested as part of the documentation builds.

Related to #88107

Screenshots

image

@lcawl lcawl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.14.0 labels Jun 15, 2021
@lcawl
Copy link
Copy Markdown
Member Author

lcawl commented Jun 16, 2021

@elasticmachine merge upstream

@lcawl lcawl marked this pull request as ready for review June 16, 2021 23:12
@lcawl lcawl requested review from a team as code owners June 16, 2021 23:12
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@lcawl
Copy link
Copy Markdown
Member Author

lcawl commented Jun 21, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

merge conflict between base and head

@lcawl lcawl requested a review from a team June 22, 2021 18:46
@lcawl lcawl added docs and removed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jun 30, 2021
@lcawl lcawl removed request for a team June 30, 2021 02:47
@lcawl lcawl changed the title Use doc links service for Security help menu Adds ECS guide to doc links service Jun 30, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 418.1KB 418.1KB +66.0B

History

  • 💚 Build #132845 succeeded 878949a58752051e812829cfd84c533aca65d45b
  • 💚 Build #131893 succeeded ea11be0df58b7b053136a501e1b235fd3049d712
  • 💔 Build #131456 failed 162df7294b9aa281009ca99397794a54f411bae8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lcawl lcawl merged commit 0fb21c4 into elastic:master Jun 30, 2021
@lcawl lcawl deleted the security-links branch June 30, 2021 04:47
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jun 30, 2021
…-png-pdf-report-type

* 'master' of github.com:elastic/kibana: (178 commits)
  [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028)
  [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850)
  [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852)
  Allow zero (0) to unset unenroll_timeout field (elastic#103790)
  [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717)
  [Query] Es query/field base (elastic#103177)
  Remove add data button from nav (elastic#103810)
  Fix telemetry advanced setting style (elastic#103838)
  [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690)
  [APM] use conventional error rate color for correlations (elastic#103500)
  Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171)
  [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663)
  fix too many rernders (elastic#103672)
  [APM] Add “Analyze Data” button (elastic#103485)
  [Lens] Fix value popover spacing (elastic#103081)
  [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926)
  [SECURITY] Adds security links to doc link service (elastic#102676)
  Update dependency @elastic/charts to v31 (elastic#102078)
  [Security Solution][CTI] Investigation time enrichment UI (elastic#103383)
  Adds ECS guide to doc links service (elastic#102246)
  ...

# Conflicts:
#	x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jul 2, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102246 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 102246 or prevent reminders by adding the backport:skip label.

@lcawl lcawl added backported and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported docs release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants