Update dependency @elastic/charts to v31.0.0 (master)#102078
Merged
Conversation
Contributor
|
@elasticmachine run elasticsearch-ci/docs |
f25a982 to
871c175
Compare
871c175 to
5019a14
Compare
Contributor
|
@elasticmachine run elasticsearch-ci/docs |
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
markov00
approved these changes
Jun 29, 2021
Contributor
There was a problem hiding this comment.
Looks good to me, the breaking changes reported in elastic/elastic-charts#1194 and relative to the onPointerUpdate listener used on the <Settings /> component in Charts does not affect the current Kibana implementation.
I've checked the listener use across Kibana: is used only to sync the cursors/tooltip between charts. I haven't found a case where the PointerEvent is used directly.
I'd like to ping few team members to review the changes on the possible affected charts:
- @sqren for
x-pack/plugins/apm/public/components/shared/charts/transaction_breakdown_chart/transaction_breakdown_chart_contents.tsx - @stratoula for
src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js - @phillipb for
x-pack/plugins/infra/public/pages/metrics/inventory_view/components/node_details/tabs/metrics/chart_section.tsxandx-pack/plugins/infra/public/pages/metrics/inventory_view/components/node_details/tabs/metrics/metrics.tsx
The way to review is to check your affected components and verify that the cursor/tooltip is correctly synched across multiple charts
stratoula
approved these changes
Jun 29, 2021
Contributor
stratoula
left a comment
There was a problem hiding this comment.
TSVB doesn't seem to be affected by this change
nickofthyme
approved these changes
Jun 29, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 30, 2021
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 30, 2021
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jun 30, 2021
…-png-pdf-report-type * 'master' of github.com:elastic/kibana: (178 commits) [test] Migrating to kbn_archiver from es_archiver - for the Maps app (elastic#103028) [Reporting] Reintroduce "ILM policy for managing reporting indices" (elastic#103850) [Security Solution][Endpoint] Allow activity log scrolling on small screens (elastic#103852) Allow zero (0) to unset unenroll_timeout field (elastic#103790) [TSVB] Metric count is depicted as `-` instead of 0 (elastic#103717) [Query] Es query/field base (elastic#103177) Remove add data button from nav (elastic#103810) Fix telemetry advanced setting style (elastic#103838) [Transform] Fix default naming and sorting fields suggestion for `top_metrics` agg (elastic#103690) [APM] use conventional error rate color for correlations (elastic#103500) Endpoint Telemetry: Agents Metrics + Policy Config / Response (elastic#102171) [Alerting] Fixed search results are not updated when search term is removed on Rules and Connectors page (elastic#103663) fix too many rernders (elastic#103672) [APM] Add “Analyze Data” button (elastic#103485) [Lens] Fix value popover spacing (elastic#103081) [TSVB] Fix TSVB is not reporting all categories of Elasticsearch error (elastic#102926) [SECURITY] Adds security links to doc link service (elastic#102676) Update dependency @elastic/charts to v31 (elastic#102078) [Security Solution][CTI] Investigation time enrichment UI (elastic#103383) Adds ECS guide to doc links service (elastic#102246) ... # Conflicts: # x-pack/plugins/reporting/public/share_context_menu/register_pdf_png_reporting.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
30.1.0->31.0.0Release Notes
elastic/elastic-charts
31.0.0 (2021-06-29)
Bug Fixes
Features
BREAKING CHANGES
PointerOverEventtype now extendsProjectedValuesand drops value. This effectively replaces value withx,y,smVerticalValueandsmHorizontalValue.30.2.0 (2021-06-10)
Features
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.