[Event Log] Populated rule.* ECS fields for alert events.#101132
Merged
YulNaumenko merged 20 commits intoelastic:masterfrom Jun 10, 2021
Merged
[Event Log] Populated rule.* ECS fields for alert events.#101132YulNaumenko merged 20 commits intoelastic:masterfrom
YulNaumenko merged 20 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
YulNaumenko
commented
Jun 4, 2021
| * 2.0. | ||
| */ | ||
|
|
||
| export const getDocsForRuleTypeByProducer = ( |
Contributor
Author
There was a problem hiding this comment.
Using hardcoded links for now. Will replace it later with the docLinks service, when the support for the server usage will be implemented (opened issue)
ymao1
reviewed
Jun 7, 2021
Contributor
ymao1
left a comment
There was a problem hiding this comment.
Can we add the new fields and descriptions to the event log README? Will make it easier keep track of what rule.id vs rule.uuid is :)
x-pack/plugins/alerting/server/lib/get_docs_for_rule_type_by_producer.ts
Outdated
Show resolved
Hide resolved
peluja1012
reviewed
Jun 8, 2021
x-pack/plugins/alerting/server/task_runner/create_execution_handler.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: cc @YulNaumenko |
pmuellr
approved these changes
Jun 10, 2021
Contributor
pmuellr
left a comment
There was a problem hiding this comment.
LGTM and works as expected
YulNaumenko
added a commit
to YulNaumenko/kibana
that referenced
this pull request
Jun 10, 2021
…1132) * [Event Log] Populated rule.* ECS fields for alert events. * added mappings * changed the params passing * fixed tests * fixed type checks * used kibanaVersion for version event rule * fixed typos * fixed tests * fixed tests * fixed tests * fixed tests * fixed jest tests * removed references * removed not populated fields * fixed tests * fixed tests * fixed tests
YulNaumenko
added a commit
that referenced
this pull request
Jun 10, 2021
…101952) * [Event Log] Populated rule.* ECS fields for alert events. * added mappings * changed the params passing * fixed tests * fixed type checks * used kibanaVersion for version event rule * fixed typos * fixed tests * fixed tests * fixed tests * fixed tests * fixed jest tests * removed references * removed not populated fields * fixed tests * fixed tests * fixed tests
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 14, 2021
* master: (68 commits) skip flaky suite (elastic#94043) skip flaky suite (elastic#102012) [esArchive] Persists updates for management/saved_objects/* (elastic#101992) skip flaky suite (elastic#101449) remove unnecessary hack (elastic#101909) [Exploratory View] Use human readable formats (elastic#101520) [Expressions] Refactor expression functions to use observables underneath (elastic#100409) [esArchives] Persist migrated Kibana archives (elastic#101950) [kbnArchiver] fix save to non-existent file (elastic#101974) [Enterprise Search] Add owner and description properties to kibana.json (elastic#101957) [DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#101696) [Observability] [Cases] Cases in the observability app (elastic#101487) [Alerting][Docs] Combine rule creation and management pages (elastic#101498) temporarily disable build-buddy [Fleet] Fix fleet server collector in case settings are not set (elastic#101752) [Event Log] Populated rule.* ECS fields for alert events. (elastic#101132) [APM] Fleet support for merging input.config values with other nested properties in the policy input (elastic#101690) Add comments to some alerting plugin public API items (elastic#101551) [Alerting][Docs] Moving alerting setup to its own page (elastic#101323) remove uptime public API, it's not used. (elastic#101799) ...
This was referenced Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #94137
Summary
Current PR contains changes which populating rule schema part of the event log:
rule.id- the ruleidfieldrule.license- rule typeminimumLicenseRequiredfieldrule.name- the rulenamefieldrule.ruleset- ruleproducerrule.category- ruleTypeidSkipped populating by the reasons:
rule.reference- not populating this till the docLinks will be supported for the server plugins: #101501rule.version,rule.author,rule.uuidandrule.descriptionfields - skip the populating and opened a discussion issue