Add comments to some alerting plugin public API items#101551
Merged
stacey-gammon merged 11 commits intoelastic:masterfrom Jun 10, 2021
Merged
Add comments to some alerting plugin public API items#101551stacey-gammon merged 11 commits intoelastic:masterfrom
stacey-gammon merged 11 commits intoelastic:masterfrom
Conversation
added 3 commits
June 7, 2021 22:18
…acey-gammon/kibana into 2021-06-07-alert-comments-api-cleanup
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Author
|
@elasticmachine merge upstream |
ymao1
approved these changes
Jun 10, 2021
Contributor
ymao1
left a comment
There was a problem hiding this comment.
LGTM with some minor wording nits!
Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: ymao1 <ying.mao@elastic.co>
Co-authored-by: ymao1 <ying.mao@elastic.co>
Contributor
💚 Build SucceededMetrics [docs]Public APIs missing comments
Public APIs missing exports
Page load bundle
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 14, 2021
* master: (68 commits) skip flaky suite (elastic#94043) skip flaky suite (elastic#102012) [esArchive] Persists updates for management/saved_objects/* (elastic#101992) skip flaky suite (elastic#101449) remove unnecessary hack (elastic#101909) [Exploratory View] Use human readable formats (elastic#101520) [Expressions] Refactor expression functions to use observables underneath (elastic#100409) [esArchives] Persist migrated Kibana archives (elastic#101950) [kbnArchiver] fix save to non-existent file (elastic#101974) [Enterprise Search] Add owner and description properties to kibana.json (elastic#101957) [DOCS] Fixes terminology in Stack Monitoring:Kibana alerts (elastic#101696) [Observability] [Cases] Cases in the observability app (elastic#101487) [Alerting][Docs] Combine rule creation and management pages (elastic#101498) temporarily disable build-buddy [Fleet] Fix fleet server collector in case settings are not set (elastic#101752) [Event Log] Populated rule.* ECS fields for alert events. (elastic#101132) [APM] Fleet support for merging input.config values with other nested properties in the policy input (elastic#101690) Add comments to some alerting plugin public API items (elastic#101551) [Alerting][Docs] Moving alerting setup to its own page (elastic#101323) remove uptime public API, it's not used. (elastic#101799) ...
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 14, 2021
* Add comments. Remove ruleType as the second param, not needed. * Add comments. Remove ruleType as the second param, not needed. * Fix bad type check and update docs * update docs * Remove unused import * change exports to type to avoid increasing bundle size * Update x-pack/plugins/alerting/public/plugin.ts Co-authored-by: ymao1 <ying.mao@elastic.co> * Update x-pack/plugins/alerting/public/plugin.ts Co-authored-by: ymao1 <ying.mao@elastic.co> * Update x-pack/plugins/alerting/public/plugin.ts Co-authored-by: ymao1 <ying.mao@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: ymao1 <ying.mao@elastic.co>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 14, 2021
) * Add comments. Remove ruleType as the second param, not needed. * Add comments. Remove ruleType as the second param, not needed. * Fix bad type check and update docs * update docs * Remove unused import * change exports to type to avoid increasing bundle size * Update x-pack/plugins/alerting/public/plugin.ts Co-authored-by: ymao1 <ying.mao@elastic.co> * Update x-pack/plugins/alerting/public/plugin.ts Co-authored-by: ymao1 <ying.mao@elastic.co> * Update x-pack/plugins/alerting/public/plugin.ts Co-authored-by: ymao1 <ying.mao@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: ymao1 <ying.mao@elastic.co> Co-authored-by: Stacey Gammon <gammon@elastic.co> Co-authored-by: ymao1 <ying.mao@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AlertNavigationHandler. No consumers were using it and it seems like it should be extractible from the rule that is passed in. Having it as a second parameter opens the door for passing in a rule type that the first parameter's rule doesn't match. What should happen then?Before:
After:
