[Enterprise Search] Fix SchemaFieldTypeSelect axe issues#100035
Merged
cee-chen merged 2 commits intoelastic:masterfrom May 13, 2021
Merged
[Enterprise Search] Fix SchemaFieldTypeSelect axe issues#100035cee-chen merged 2 commits intoelastic:masterfrom
cee-chen merged 2 commits intoelastic:masterfrom
Conversation
- We'll specifically be using aria-labelledby in this PR, but theoretically any aria prop should be fine.
…an aria-labelledby ID
Contributor
Author
|
Side note: the only other use of
|
JasonStoltz
approved these changes
May 13, 2021
Contributor
Author
|
Thanks y'all! |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 13, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 13, 2021
…100069) * Update SchemaFieldTypeSelect to allow passing any aria props - We'll specifically be using aria-labelledby in this PR, but theoretically any aria prop should be fine. * Update AS & WS schema tables to use the type table column heading as an aria-labelledby ID Co-authored-by: Constance <constancecchen@users.noreply.github.com>
gmmorris
added a commit
to chrisronline/kibana
that referenced
this pull request
May 14, 2021
* master: (27 commits) Disable contextMenu when event is not event.kind=event (elastic#100027) Updates the monorepo-packages list (elastic#100096) Removes circular deps for lists in tooling and bumps down byte limit for lists (elastic#100082) [Security Solutions] Breaks down the io-ts packages to decrease plugin size (elastic#100058) fix-typo: Use of `than` instead of `then` (elastic#100030) [Fleet] Fix error when searching for keys whose names have spaces (elastic#100056) [Workplace Search] Fix bug when transitioning to personal dashboard (elastic#100061) [index pattern field editor] Update runtime field painless docs url (elastic#100014) [QA] Switch tests to use importExport - visualize (elastic#98063) [Canvas] Remove unused legacy autocomplete component (elastic#99215) Re-enable formerly flaky shareable test (elastic#98826) [Uptime] [Synthetics Integration] ensure that proxy url is not overwritten (elastic#99944) [Security Solutions][Lists] Trims down list plugin size by breaking out the exception builder into chunks by using react lazy loading (elastic#99989) [Uptime] Increase debounce and add immediate submit to `useQueryBar` (elastic#99675) chore(NA): moving @kbn/docs-utils into bazel (elastic#100051) [Enterprise Search] Fix SchemaFieldTypeSelect axe issues (elastic#100035) Remove outdated comment about schema validation not working (it does work now). (elastic#100055) Rename alert status OK to Recovered and fix some UX issues around disabling a rule while being in an error state (elastic#98135) [Fleet] Do not use async method in plugin setup|start (elastic#100033) Skip flaky functional test suite ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shared
<SchemaFieldTypeSelect />component currently used in our schema table components was registering an axe failure for each select, because it was missing alabelof some kind (in this case, I simply usedaria-labelledbyto re-use the table column heading as a label).Before
After
Checklist
Functionally, I didn't notice a difference while QAing in VoiceOver in FIrefox, but I think that's because the select is in a table - so the table column heading already comes before the cell content while navigating.