Skip to content

[7.x] [Enterprise Search] Fix SchemaFieldTypeSelect axe issues (#100035)#100069

Merged
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-100035
May 13, 2021
Merged

[7.x] [Enterprise Search] Fix SchemaFieldTypeSelect axe issues (#100035)#100069
kibanamachine merged 1 commit intoelastic:7.xfrom
kibanamachine:backport/7.x/pr-100035

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

@kibanamachine kibanamachine commented May 13, 2021

Backports the following commits to 7.x:

@kibanamachine
[Enterprise Search] Fix SchemaFieldTypeSelect axe issues (elastic#100035
234f156 
)

* Update SchemaFieldTypeSelect to allow passing any aria props

- We'll specifically be using aria-labelledby in this PR, but theoretically any aria prop should be fine.

* Update AS & WS schema tables to use the type table column heading as an aria-labelledby ID
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label May 13, 2021
@kibanamachine kibanamachine enabled auto-merge (squash) May 13, 2021 19:14
@kibanamachine kibanamachine mentioned this pull request May 13, 2021
Merged
1 task
@kibanamachine
Copy link
Copy Markdown
Contributor Author

kibanamachine commented May 13, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.1MB 2.1MB +408.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -69

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @constancecchen

@kibanamachine kibanamachine merged commit 24233c6 into elastic:7.x May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cee-chen cee-chen

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kibanamachine @cee-chen