Gracefully handle malformed index patterns on role management pages (#99918) (#100053)

kibanamachine · legrego · web-flow · commit 2a85ef76b48a · 2021-05-13T14:25:54.000-04:00
Co-authored-by: Larry Gregory &lt;larry.gregory@elastic.co&gt;
diff --git a/x-pack/plugins/security/public/management/roles/edit_role/edit_role_page.test.tsx b/x-pack/plugins/security/public/management/roles/edit_role/edit_role_page.test.tsx
@@ -143,7 +143,8 @@ function getProps({
   rolesAPIClient.getRole.mockResolvedValue(role);
 
   const indexPatterns = dataPluginMock.createStartContract().indexPatterns;
-  indexPatterns.getTitles = jest.fn().mockResolvedValue(['foo*', 'bar*']);
+  // `undefined` titles can technically happen via import/export or other manual manipulation
+  indexPatterns.getTitles = jest.fn().mockResolvedValue(['foo*', 'bar*', undefined]);
 
   const indicesAPIClient = indicesAPIClientMock.create();
 
diff --git a/x-pack/plugins/security/public/management/roles/edit_role/edit_role_page.tsx b/x-pack/plugins/security/public/management/roles/edit_role/edit_role_page.tsx
@@ -125,7 +125,7 @@ function useIndexPatternsTitles(
         fatalErrors.add(err);
         throw err;
       })
-      .then(setIndexPatternsTitles);
+      .then((titles) => setIndexPatternsTitles(titles.filter(Boolean)));
   }, [fatalErrors, indexPatterns, notifications]);
 
   return indexPatternsTitles;
