Skip to content

[QA] Switch tests to use importExport - visualize#98063

Merged
wayneseymour merged 26 commits intomasterfrom
kbnarchiver-switch-visualize
May 13, 2021
Merged

[QA] Switch tests to use importExport - visualize#98063
wayneseymour merged 26 commits intomasterfrom
kbnarchiver-switch-visualize

Conversation

@wayneseymour
Copy link
Copy Markdown
Contributor

@wayneseymour wayneseymour commented Apr 22, 2021

Switch the visualize tests to use kbnarchiver and not es archiver, where appropriate.

@wayneseymour wayneseymour added the release_note:skip Skip the PR/issue when compiling release notes label Apr 22, 2021
@wayneseymour wayneseymour self-assigned this Apr 22, 2021
@wayneseymour wayneseymour force-pushed the kbnarchiver-switch-visualize branch 9 times, most recently from 11f7cd9 to c6659d4 Compare April 29, 2021 11:11
@wayneseymour wayneseymour marked this pull request as ready for review April 29, 2021 15:18
dmlemeshko
dmlemeshko reviewed Apr 29, 2021
View reviewed changes
@wayneseymour wayneseymour requested a review from dmlemeshko April 29, 2021 15:38
dmlemeshko
dmlemeshko reviewed Apr 29, 2021
View reviewed changes
@wayneseymour wayneseymour requested a review from dmlemeshko April 29, 2021 17:24
dmlemeshko
dmlemeshko reviewed Apr 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, last question about initTests()

@wayneseymour wayneseymour requested a review from dmlemeshko April 29, 2021 21:27
dmlemeshko
dmlemeshko reviewed Apr 29, 2021
View reviewed changes
@wayneseymour
Copy link
Copy Markdown
Contributor Author

wayneseymour commented May 3, 2021

@elasticmachine merge upstream

LeeDr
LeeDr suggested changes May 3, 2021
View reviewed changes
Copy link
Copy Markdown

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try to move the init to the visualize_page so all tests could call it from their before method.

@wayneseymour wayneseymour force-pushed the kbnarchiver-switch-visualize branch 2 times, most recently from 77704b7 to 3a9c9af Compare May 3, 2021 19:49
@wayneseymour
[QA] Switch tests to use importExport - visualize
d9d32a4 
Switch visualize tests to use kbnarchiver instead of esarchvier

Partially closes #93797
@wayneseymour
Cleanup
7f1b809
@wayneseymour
Use initTests everywhere
afe7de9
@wayneseymour
Fixup
27a0022
@wayneseymour wayneseymour added v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels May 13, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 13, 2021

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 4 2 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 5 3 -2
licensing 18 15 -3
monitoring 109 56 -53
total -73

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @wayneseymour

@wayneseymour wayneseymour merged commit 6f95145 into master May 13, 2021
@wayneseymour wayneseymour deleted the kbnarchiver-switch-visualize branch May 13, 2021 20:33
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 13, 2021

💔 Backport failed

Status Branch Result
❌ 7.x Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 98063

gmmorris added a commit to chrisronline/kibana that referenced this pull request May 14, 2021
@gmmorris
Merge branch 'master' into pr/97311
44babf8 
* master: (27 commits)
  Disable contextMenu when event is not event.kind=event (elastic#100027)
  Updates the monorepo-packages list (elastic#100096)
  Removes circular deps for lists in tooling and bumps down byte limit for lists (elastic#100082)
  [Security Solutions] Breaks down the io-ts packages to decrease plugin size (elastic#100058)
  fix-typo: Use of `than` instead of `then` (elastic#100030)
  [Fleet] Fix error when searching for keys whose names have spaces (elastic#100056)
  [Workplace Search] Fix bug when transitioning to personal dashboard (elastic#100061)
  [index pattern field editor] Update runtime field painless docs url (elastic#100014)
  [QA] Switch tests to use importExport - visualize (elastic#98063)
  [Canvas] Remove unused legacy autocomplete component (elastic#99215)
  Re-enable formerly flaky shareable test (elastic#98826)
  [Uptime] [Synthetics Integration] ensure that proxy url is not overwritten (elastic#99944)
  [Security Solutions][Lists] Trims down list plugin size by breaking out the exception builder into chunks by using react lazy loading (elastic#99989)
  [Uptime] Increase debounce and add immediate submit to `useQueryBar` (elastic#99675)
  chore(NA): moving @kbn/docs-utils into bazel (elastic#100051)
  [Enterprise Search] Fix SchemaFieldTypeSelect axe issues (elastic#100035)
  Remove outdated comment about schema validation not working (it does work now). (elastic#100055)
  Rename alert status OK to Recovered and fix some UX issues around disabling a rule while being in an error state (elastic#98135)
  [Fleet] Do not use async method in plugin setup|start (elastic#100033)
  Skip flaky functional test suite
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 17, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 17, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

6 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 18, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 19, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 19, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 20, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 21, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 24, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@wayneseymour @kibanamachine @yctercero
[QA] Switch tests to use importExport - visualize (elastic#98063)
e6c88d7 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 25, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

7 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 26, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 27, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 28, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 31, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 1, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 2, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 3, 2021

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 98063 or prevent reminders by adding the backport:skip label.

stratoula pushed a commit to stratoula/kibana that referenced this pull request Jun 4, 2021
@wayneseymour @kibanamachine @stratoula
[QA] Switch tests to use importExport - visualize (elastic#98063)
851db2a 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	test/functional/apps/visualize/index.ts
@stratoula stratoula mentioned this pull request Jun 4, 2021
Merged
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 4, 2021
stratoula added a commit that referenced this pull request Jun 4, 2021
@stratoula @wayneseymour
[QA] Switch tests to use importExport - visualize (#98063) (#101361)
ab06dc1 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
# Conflicts:
#	test/functional/apps/visualize/index.ts

Co-authored-by: Tre <wayne.seymour@elastic.co>
@stratoula stratoula mentioned this pull request Jun 7, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmlemeshko dmlemeshko Awaiting requested review from dmlemeshko

1 more reviewer

@LeeDr LeeDr LeeDr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@wayneseymour wayneseymour

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wayneseymour @kibanamachine @dmlemeshko @LeeDr