Skip to content

Commit bbee1ef

Browse files
jloleysensjloleysens
committed
Merge branch 'master' of github.com:elastic/kibana into console-proxy-fallback
* 'master' of github.com:elastic/kibana: (116 commits) [Maps] move apply global filter settting from layer to source (#50523) [SIEM] Fix: Empty `Source` / `Destination` shown when only ports are populated (#50843) [Maps] Delay vector tile layer syncing until spritesheet is loaded (#48955) [Maps] prevent users from overflowing URL when filtering by shape (#50747) [DOCS] Mark Beats central management as discontinued (#49423) [page_objects/common_page] convert to ts (#50771) [NP Kibana Migrations ] kibana plugin home (#50444) [DOCS] Shareables naming convention (#50497) [ML] DF Analytics - auto-populate model_memory_limit (#50714) Increase alerting test stability and reduce flakiness (#50246) [ML] Remaning new_job_new folder (#50917) [Telemetry] Show opt-in changes for OSS users (#50831) [ML] Fix lat_long anomalies table links menu and value formatting (#50916) [Dev] Fix serialising a really big string (#50915) Better explanation about the Prettier recommendation (extension vs. NPM module) (#50629) [Monitoring] Use a basic monitoring user for tests (#47865) [Monitoring] Gracefully handle issue with filebeat indices (#48929) [Monitoring] Improve permissions required around setup mode (#50421) Additional validation for elasticsearch username (#48247) Revert changes to use_kibana_ui_setting (#50877) ... # Conflicts: # src/legacy/core_plugins/console/server/request.test.ts
2 parents 53d4223 + e2dc921 commit bbee1ef

2,072 files changed

Lines changed: 38327 additions & 14441 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.ci/Jenkinsfile_flaky‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ stage("Kibana Pipeline") {
3434
if (!IS_XPACK) {
3535
kibanaPipeline.buildOss()
3636
if (CI_GROUP == '1') {
37-
runbld "./test/scripts/jenkins_build_kbn_tp_sample_panel_action.sh"
37+
runbld("./test/scripts/jenkins_build_kbn_tp_sample_panel_action.sh", "Build kbn tp sample panel action for ciGroup1")
3838
}
3939
} else {
4040
kibanaPipeline.buildXpack()
@@ -62,18 +62,18 @@ stage("Kibana Pipeline") {
6262
def getWorkerFromParams(isXpack, job, ciGroup) {
6363
if (!isXpack) {
6464
if (job == 'firefoxSmoke') {
65-
return kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld './test/scripts/jenkins_firefox_smoke.sh' })
65+
return kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld('./test/scripts/jenkins_firefox_smoke.sh', 'Execute kibana-firefoxSmoke') })
6666
} else if(job == 'visualRegression') {
67-
return kibanaPipeline.getPostBuildWorker('visualRegression', { runbld './test/scripts/jenkins_visual_regression.sh' })
67+
return kibanaPipeline.getPostBuildWorker('visualRegression', { runbld('./test/scripts/jenkins_visual_regression.sh', 'Execute kibana-visualRegression') })
6868
} else {
6969
return kibanaPipeline.getOssCiGroupWorker(ciGroup)
7070
}
7171
}
7272

7373
if (job == 'firefoxSmoke') {
74-
return kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld './test/scripts/jenkins_xpack_firefox_smoke.sh' })
74+
return kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld('./test/scripts/jenkins_xpack_firefox_smoke.sh', 'Execute xpack-firefoxSmoke') })
7575
} else if(job == 'visualRegression') {
76-
return kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld './test/scripts/jenkins_xpack_visual_regression.sh' })
76+
return kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld('./test/scripts/jenkins_xpack_visual_regression.sh', 'Execute xpack-visualRegression') })
7777
} else {
7878
return kibanaPipeline.getXpackCiGroupWorker(ciGroup)
7979
}

‎.eslintrc.js‎

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -214,13 +214,6 @@ module.exports = {
214214
'jsx-a11y/click-events-have-key-events': 'off',
215215
},
216216
},
217-
{
218-
files: ['x-pack/legacy/plugins/siem/**/*.{js,ts,tsx}'],
219-
rules: {
220-
'react-hooks/exhaustive-deps': 'off',
221-
'react-hooks/rules-of-hooks': 'off',
222-
},
223-
},
224217
{
225218
files: ['x-pack/legacy/plugins/snapshot_restore/**/*.{js,ts,tsx}'],
226219
rules: {
@@ -839,6 +832,8 @@ module.exports = {
839832
// might be introduced after the other warns are fixed
840833
// 'react/jsx-sort-props': 'error',
841834
'react/jsx-tag-spacing': 'error',
835+
// might be introduced after the other warns are fixed
836+
'react-hooks/exhaustive-deps': 'off',
842837
'require-atomic-updates': 'error',
843838
'rest-spread-spacing': ['error', 'never'],
844839
'symbol-description': 'error',

‎.github/CODEOWNERS‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,6 @@
2828
# Canvas
2929
/x-pack/legacy/plugins/canvas/ @elastic/kibana-canvas
3030

31-
# Code
32-
/x-pack/legacy/plugins/code/ @teams/code
33-
/x-pack/test/functional/apps/code/ @teams/code
34-
/x-pack/test/api_integration/apis/code/ @teams/code
35-
3631
# Logs & Metrics UI
3732
/x-pack/legacy/plugins/infra/ @elastic/logs-metrics-ui
3833
/x-pack/legacy/plugins/integrations_manager/ @elastic/epm

‎.i18nrc.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
"kibana_react": "src/legacy/core_plugins/kibana_react",
2121
"kibana-react": "src/plugins/kibana_react",
2222
"navigation": "src/legacy/core_plugins/navigation",
23+
"newsfeed": "src/plugins/newsfeed",
2324
"regionMap": "src/legacy/core_plugins/region_map",
2425
"server": "src/legacy/server",
2526
"statusPage": "src/legacy/core_plugins/status_page",

‎.sass-lint.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ files:
22
include:
33
- 'src/legacy/core_plugins/metrics/**/*.s+(a|c)ss'
44
- 'src/legacy/core_plugins/timelion/**/*.s+(a|c)ss'
5-
- 'src/legacy/ui/public/query_bar/**/*.s+(a|c)ss'
65
- 'src/legacy/ui/public/vislib/**/*.s+(a|c)ss'
76
- 'x-pack/legacy/plugins/rollup/**/*.s+(a|c)ss'
87
- 'x-pack/legacy/plugins/security/**/*.s+(a|c)ss'

‎CONTRIBUTING.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ Note that for VSCode, to enable "live" linting of TypeScript (and other) file ty
325325
"eslint.autoFixOnSave": true,
326326
```
327327

328-
It is **not** recommended to use `prettier` plugin on Kibana project. Because settings are in `eslintrc.js` file and it is applied to too many files that shouldn't be prettier-ized.
328+
:warning: It is **not** recommended to use the [`Prettier` extension/IDE plugin](https://prettier.io/) while maintaining the Kibana project. Formatting and styling roles are set in the multiple `.eslintrc.js` files across the project and some of them use the [NPM version of Prettier](https://www.npmjs.com/package/prettier). Using the IDE extension might cause conflicts, applying the formatting to too many files that shouldn't be prettier-ized and/or highlighting errors that are actually OK.
329329

330330
### Internationalization
331331

‎Jenkinsfile‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
2424
'oss-ciGroup10': kibanaPipeline.getOssCiGroupWorker(10),
2525
'oss-ciGroup11': kibanaPipeline.getOssCiGroupWorker(11),
2626
'oss-ciGroup12': kibanaPipeline.getOssCiGroupWorker(12),
27-
'oss-firefoxSmoke': kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld './test/scripts/jenkins_firefox_smoke.sh' }),
28-
'oss-accessibility': kibanaPipeline.getPostBuildWorker('accessibility', { runbld './test/scripts/jenkins_accessibility.sh' }),
29-
'oss-visualRegression': kibanaPipeline.getPostBuildWorker('visualRegression', { runbld './test/scripts/jenkins_visual_regression.sh' }),
27+
'oss-firefoxSmoke': kibanaPipeline.getPostBuildWorker('firefoxSmoke', { runbld('./test/scripts/jenkins_firefox_smoke.sh', 'Execute kibana-firefoxSmoke') }),
28+
'oss-accessibility': kibanaPipeline.getPostBuildWorker('accessibility', { runbld('./test/scripts/jenkins_accessibility.sh', 'Execute kibana-accessibility') }),
29+
'oss-visualRegression': kibanaPipeline.getPostBuildWorker('visualRegression', { runbld('./test/scripts/jenkins_visual_regression.sh', 'Execute kibana-visualRegression') }),
3030
]),
3131
'kibana-xpack-agent': kibanaPipeline.withWorkers('kibana-xpack-tests', { kibanaPipeline.buildXpack() }, [
3232
'xpack-ciGroup1': kibanaPipeline.getXpackCiGroupWorker(1),
@@ -39,9 +39,9 @@ stage("Kibana Pipeline") { // This stage is just here to help the BlueOcean UI a
3939
'xpack-ciGroup8': kibanaPipeline.getXpackCiGroupWorker(8),
4040
'xpack-ciGroup9': kibanaPipeline.getXpackCiGroupWorker(9),
4141
'xpack-ciGroup10': kibanaPipeline.getXpackCiGroupWorker(10),
42-
'xpack-firefoxSmoke': kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld './test/scripts/jenkins_xpack_firefox_smoke.sh' }),
43-
'xpack-accessibility': kibanaPipeline.getPostBuildWorker('xpack-accessibility', { runbld './test/scripts/jenkins_xpack_accessibility.sh' }),
44-
'xpack-visualRegression': kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld './test/scripts/jenkins_xpack_visual_regression.sh' }),
42+
'xpack-firefoxSmoke': kibanaPipeline.getPostBuildWorker('xpack-firefoxSmoke', { runbld('./test/scripts/jenkins_xpack_firefox_smoke.sh', 'Execute xpack-firefoxSmoke') }),
43+
'xpack-accessibility': kibanaPipeline.getPostBuildWorker('xpack-accessibility', { runbld('./test/scripts/jenkins_xpack_accessibility.sh', 'Execute xpack-accessibility') }),
44+
'xpack-visualRegression': kibanaPipeline.getPostBuildWorker('xpack-visualRegression', { runbld('./test/scripts/jenkins_xpack_visual_regression.sh', 'Execute xpack-visualRegression') }),
4545
]),
4646
])
4747
}

‎STYLEGUIDE.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ You should prefer modern language features in a lot of cases, e.g.:
120120
* Prefer arrow function over storing `this` (no `const self = this;`)
121121
* Prefer template strings over string concatenation
122122
* Prefer the spread operator for copying arrays (`[...arr]`) over `arr.slice()`
123+
* Use optional chaining (`?.`) and nullish Coalescing (`??`) over `lodash.get` (and similar utilities)
123124
124125
### Avoid mutability and state
125126

‎docs/canvas/canvas-share-workpad.asciidoc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ image::images/canvas-create-URL.gif[Create POST URL]
5555
[[add-workpad-website]]
5656
=== Share the workpad on a website
5757

58-
beta[] Download the workpad and share it on any website, then customize the workpad behavior to autoplay the pages or hide the toolbar.
58+
beta[] Canvas allows you to create _shareables_, which are workpads that you download and securely share on any website. To customize the behavior of the workpad on your website, you can choose to autoplay the pages or hide the workpad toolbar.
5959

6060
. If you are using a Gold or Platinum license, enable reporting in your `config/kibana.yml` file.
6161

@@ -74,7 +74,7 @@ NOTE: Shareable workpads encode the current state of the workpad in a JSON file.
7474

7575
[float]
7676
[[change-the-workpad-settings]]
77-
=== Change the shareable workpad settings
77+
=== Change the settings
7878

7979
After you've added the workpad to your website, you can change the autoplay and toolbar settings.
8080

‎docs/development/core/public/kibana-plugin-public.app.chromeless.md‎

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<!-- Do not edit this file. It is automatically generated by API Documenter. -->
2+
3+
[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [App](./kibana-plugin-public.app.md) &gt; [chromeless](./kibana-plugin-public.app.chromeless.md)
4+
5+
## App.chromeless property
6+
7+
Hide the UI chrome when the application is mounted. Defaults to `false`<!-- -->. Takes precedence over chrome service visibility settings.
8+
9+
<b>Signature:</b>
10+
11+
```typescript
12+
chromeless?: boolean;
13+
```

0 commit comments

Comments
 (0)