pipeline tests - Ignore url.extension for ES < 8.14#10685
Merged
kcreddy merged 2 commits intoelastic:mainfrom Aug 6, 2024
Merged
pipeline tests - Ignore url.extension for ES < 8.14#10685kcreddy merged 2 commits intoelastic:mainfrom
kcreddy merged 2 commits intoelastic:mainfrom
Conversation
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
reviewed
Aug 5, 2024
Contributor
efd6
left a comment
There was a problem hiding this comment.
Do we want version-next in the changelog?
packages/f5_bigip/data_stream/log/_dev/test/pipeline/test-common-config.yml
Outdated
Show resolved
Hide resolved
Contributor
Author
Contributor
|
I'm fine with what is here. |
efd6
approved these changes
Aug 6, 2024
💚 Build Succeeded
History
cc @kcreddy |
|
This was referenced Sep 6, 2024
kcreddy
added a commit
that referenced
this pull request
Jan 17, 2025
- Add geoip processor on source(client) and destination(server) IPs as relevant for each log type. - Remove url.extension from dynamic_fields list added in pipeline tests in #10685 as minimum kibana version requirement is met.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
Extension to elastic#9623 Ignore the existence of an invalid url.extension field. Stack versions < 8.14 had a bug that populated the field with bad data. After a package uses a minimum stack version of 8.14.0 then this addition to dynamic_fields can be removed. This fixes errors like this which occur under v8.14.0+ +++ got @@ -1797,7 +1797,6 @@ "preserve_duplicate_custom_fields" ], "url": { - "extension": "com/page", "original": "www.example.com/page", "path": "www.example.com/page" } Relates: elastic/elasticsearch#105689
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
- Add geoip processor on source(client) and destination(server) IPs as relevant for each log type. - Remove url.extension from dynamic_fields list added in pipeline tests in elastic#10685 as minimum kibana version requirement is met.
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
Extension to elastic#9623 Ignore the existence of an invalid url.extension field. Stack versions < 8.14 had a bug that populated the field with bad data. After a package uses a minimum stack version of 8.14.0 then this addition to dynamic_fields can be removed. This fixes errors like this which occur under v8.14.0+ +++ got @@ -1797,7 +1797,6 @@ "preserve_duplicate_custom_fields" ], "url": { - "extension": "com/page", "original": "www.example.com/page", "path": "www.example.com/page" } Relates: elastic/elasticsearch#105689
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
- Add geoip processor on source(client) and destination(server) IPs as relevant for each log type. - Remove url.extension from dynamic_fields list added in pipeline tests in elastic#10685 as minimum kibana version requirement is met.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Extension to #9623
Ignore the existence of an invalid
url.extensionfield. Stack versions < 8.14had a bug that populated the field with bad data. After a package uses a minimum
stack version of 8.14.0 then this addition to dynamic_fields can be removed.
This fixes errors like this which occur under v8.14.0+
Checklist
changelog.ymlfile.Related issues
uri_partsprocessor behaviour for missing extensions elasticsearch#105689