pipeline tests - Ignore url.extension for ES < 8.14#9623
Merged
andrewkroh merged 1 commit intoelastic:mainfrom Apr 17, 2024
andrewkroh:bugfix/es-8-14-url-extension
Merged
pipeline tests - Ignore url.extension for ES < 8.14#9623andrewkroh merged 1 commit intoelastic:mainfrom andrewkroh:bugfix/es-8-14-url-extension
andrewkroh merged 1 commit intoelastic:mainfrom
andrewkroh:bugfix/es-8-14-url-extension
Conversation
Ignore the existence of an invalid `url.extension` field. Stack versions < 8.14 had a
bug that populated the field with bad data. After a package uses a minimum stack version
of 8.14.0 then this addition to `dynamic_fields` can be removed.
This fixes errors like this which occur under v8.14.0
test case failed: Expected results are different from actual ones: --- want
+++ got
@@ -1797,7 +1797,6 @@
"preserve_duplicate_custom_fields"
],
"url": {
- "extension": "com/page",
"original": "www.example.com/page",
"path": "www.example.com/page"
}
Relates: elastic/elasticsearch#105689
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
🚀 Benchmarks reportTo see the full report comment with |
|
💚 Build Succeeded
|
This was referenced Jul 31, 2024
kcreddy
added a commit
that referenced
this pull request
Aug 6, 2024
Extension to #9623 Ignore the existence of an invalid url.extension field. Stack versions < 8.14 had a bug that populated the field with bad data. After a package uses a minimum stack version of 8.14.0 then this addition to dynamic_fields can be removed. This fixes errors like this which occur under v8.14.0+ +++ got @@ -1797,7 +1797,6 @@ "preserve_duplicate_custom_fields" ], "url": { - "extension": "com/page", "original": "www.example.com/page", "path": "www.example.com/page" } Relates: elastic/elasticsearch#105689
7 tasks
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 4, 2025
Extension to elastic#9623 Ignore the existence of an invalid url.extension field. Stack versions < 8.14 had a bug that populated the field with bad data. After a package uses a minimum stack version of 8.14.0 then this addition to dynamic_fields can be removed. This fixes errors like this which occur under v8.14.0+ +++ got @@ -1797,7 +1797,6 @@ "preserve_duplicate_custom_fields" ], "url": { - "extension": "com/page", "original": "www.example.com/page", "path": "www.example.com/page" } Relates: elastic/elasticsearch#105689
harnish-crest-data
pushed a commit
to chavdaharnish/integrations
that referenced
this pull request
Feb 5, 2025
Extension to elastic#9623 Ignore the existence of an invalid url.extension field. Stack versions < 8.14 had a bug that populated the field with bad data. After a package uses a minimum stack version of 8.14.0 then this addition to dynamic_fields can be removed. This fixes errors like this which occur under v8.14.0+ +++ got @@ -1797,7 +1797,6 @@ "preserve_duplicate_custom_fields" ], "url": { - "extension": "com/page", "original": "www.example.com/page", "path": "www.example.com/page" } Relates: elastic/elasticsearch#105689
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Ignore the existence of an invalid
url.extensionfield. Stack versions < 8.14 had a bug that populated the field with bad data. After a package uses a minimum stack version of 8.14.0 then this addition todynamic_fieldscan be removed.This fixes errors like this which occur under v8.14.0
Relates: elastic/elasticsearch#105689
Checklist
changelog.ymlfile.Related issues
uri_partsprocessor behaviour for missing extensions elasticsearch#105689CI