Skip to content

f5_bigip: Add geo enrichment#12355

Merged
kcreddy merged 0 commit intoelastic:mainfrom
kcreddy:f5_bigip-geo-enh
Jan 17, 2025
Merged

f5_bigip: Add geo enrichment#12355
kcreddy merged 0 commit intoelastic:mainfrom
kcreddy:f5_bigip-geo-enh

Conversation

@kcreddy
Copy link
Copy Markdown
Contributor

@kcreddy kcreddy commented Jan 15, 2025 •
edited
Loading

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

cd packages/f5_bigip && elastic-package stack down && elastic-package build && elastic-package stack up --version=8.16.2 -d -v && elastic-package test pipeline --generate -v

--- Test results for package: f5_bigip - START ---
╭──────────┬─────────────┬───────────┬────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE  │ DATA STREAM │ TEST TYPE │ TEST NAME                                                      │ RESULT │ TIME ELAPSED │
├──────────┼─────────────┼───────────┼────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ f5_bigip │ log         │ pipeline  │ (ingest pipeline warnings test-pipeline-bigip-afm.log)         │ PASS   │   350.8375ms │
│ f5_bigip │ log         │ pipeline  │ (ingest pipeline warnings test-pipeline-bigip-apm.log)         │ PASS   │  347.74125ms │
│ f5_bigip │ log         │ pipeline  │ (ingest pipeline warnings test-pipeline-bigip-asm.log)         │ PASS   │ 454.221333ms │
│ f5_bigip │ log         │ pipeline  │ (ingest pipeline warnings test-pipeline-bigip-avr.log)         │ PASS   │ 365.005167ms │
│ f5_bigip │ log         │ pipeline  │ (ingest pipeline warnings test-pipeline-bigip-dos-and-bot.log) │ PASS   │ 331.092416ms │
│ f5_bigip │ log         │ pipeline  │ (ingest pipeline warnings test-pipeline-bigip-ihealth.log)     │ PASS   │ 365.564041ms │
│ f5_bigip │ log         │ pipeline  │ (ingest pipeline warnings test-pipeline-bigip-ltm.log)         │ PASS   │ 408.056375ms │
│ f5_bigip │ log         │ pipeline  │ (ingest pipeline warnings test-pipeline-bigip-system.log)      │ PASS   │ 346.079458ms │
│ f5_bigip │ log         │ pipeline  │ test-pipeline-bigip-afm.log                                    │ PASS   │ 150.587583ms │
│ f5_bigip │ log         │ pipeline  │ test-pipeline-bigip-apm.log                                    │ PASS   │ 114.974875ms │
│ f5_bigip │ log         │ pipeline  │ test-pipeline-bigip-asm.log                                    │ PASS   │ 186.429875ms │
│ f5_bigip │ log         │ pipeline  │ test-pipeline-bigip-avr.log                                    │ PASS   │ 151.282416ms │
│ f5_bigip │ log         │ pipeline  │ test-pipeline-bigip-dos-and-bot.log                            │ PASS   │  89.509667ms │
│ f5_bigip │ log         │ pipeline  │ test-pipeline-bigip-ihealth.log                                │ PASS   │  86.466208ms │
│ f5_bigip │ log         │ pipeline  │ test-pipeline-bigip-ltm.log                                    │ PASS   │    123.008ms │
│ f5_bigip │ log         │ pipeline  │ test-pipeline-bigip-system.log                                 │ PASS   │  92.187041ms │
╰──────────┴─────────────┴───────────┴────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: f5_bigip - END   ---
Done

Related issues

Screenshots

@kcreddy kcreddy self-assigned this Jan 15, 2025
@kcreddy kcreddy added enhancement New feature or request Integration:f5_bigip F5 BIG-IP Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 15, 2025
@kcreddy kcreddy marked this pull request as ready for review January 15, 2025 10:37
@kcreddy kcreddy requested a review from a team as a code owner January 15, 2025 10:37
@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 15, 2025

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Jan 15, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Jan 15, 2025

💚 Build Succeeded

cc @kcreddy

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Jan 15, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

chemamartinez
chemamartinez approved these changes Jan 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy merged commit dd3daee into elastic:main Jan 17, 2025
@kcreddy kcreddy deleted the f5_bigip-geo-enh branch January 17, 2025 09:19
@elastic-vault-github-plugin-prod
Copy link
Copy Markdown

elastic-vault-github-plugin-prod bot commented Jan 17, 2025

Package f5_bigip - 1.24.0 containing this change is available at https://epr.elastic.co/package/f5_bigip/1.24.0/

harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 4, 2025
@kcreddy
f5_bigip: Add geo enrichment (elastic#12355)
a84f69a 
- Add geoip processor on source(client) and destination(server) IPs as relevant for each log type.
- Remove url.extension from dynamic_fields list added in pipeline tests in elastic#10685 as minimum kibana version requirement is met.
harnish-crest-data pushed a commit to chavdaharnish/integrations that referenced this pull request Feb 5, 2025
@kcreddy
f5_bigip: Add geo enrichment (elastic#12355)
d33e26d 
- Add geoip processor on source(client) and destination(server) IPs as relevant for each log type.
- Remove url.extension from dynamic_fields list added in pipeline tests in elastic#10685 as minimum kibana version requirement is met.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chemamartinez chemamartinez chemamartinez approved these changes

Assignees

@kcreddy kcreddy

Labels

enhancement New feature or request Integration:f5_bigip F5 BIG-IP Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kcreddy @elasticmachine @chemamartinez