[New Nav Feature] Move collapsible nav toggle button to be part of EuiCollapsibleNav#3168
Merged
cchaos merged 7 commits intoelastic:feature/collapsible_navfrom Mar 26, 2020
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3168/ |
Contributor
Author
Contributor
|
Do you still want to make this change then? |
Contributor
Author
|
Yes because at the very least it allows us to control the aria-labels for the toggle button and anything else that might be drummed up in implementation. |
myasonik
approved these changes
Mar 25, 2020
Contributor
myasonik
left a comment
There was a problem hiding this comment.
LGTM! One small change that's not even directly related to this work...
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3168/ |
8 tasks
myasonik
approved these changes
Mar 26, 2020
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3168/ |
ryankeairns
approved these changes
Mar 26, 2020
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
Text looks good, ty!
Co-Authored-By: Greg Thompson <thompson.glowe@gmail.com>
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3168/ |
cchaos
added a commit
that referenced
this pull request
Mar 26, 2020
…iCollapsibleNav (#3168) * Move collapsible nav toggle button to be part of EuiCollapsibleNav * No role group * Alterations to top links and added `pinnable` prop to pinnable list items
cchaos
added a commit
that referenced
this pull request
Mar 27, 2020
* [Feature] Added `EuiCollapsibleNav` component (#2977) * [New Nav Feature] Added `ghost` colored EuiListGroupItem (#3018) * [New Nav Feature] Created `EuiCollapsibleGroup` (#3031) * [New Nav Feature] EuiPinnableListGroup (#3061) * [K8 Nav Feature] Added `home` and `menu` glyphs to EuiIcon (#3109) * [New Nav Feature] Final docs examples and patterns (#3117) * [New Nav Feature] Move collapsible nav toggle button to be part of EuiCollapsibleNav (#3168)
elizabetdev
pushed a commit
to elizabetdev/eui
that referenced
this pull request
Mar 30, 2020
* [Feature] Added `EuiCollapsibleNav` component (elastic#2977) * [New Nav Feature] Added `ghost` colored EuiListGroupItem (elastic#3018) * [New Nav Feature] Created `EuiCollapsibleGroup` (elastic#3031) * [New Nav Feature] EuiPinnableListGroup (elastic#3061) * [K8 Nav Feature] Added `home` and `menu` glyphs to EuiIcon (elastic#3109) * [New Nav Feature] Final docs examples and patterns (elastic#3117) * [New Nav Feature] Move collapsible nav toggle button to be part of EuiCollapsibleNav (elastic#3168)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better for accessibility
Instead of forcing the consumer to remember all the
aria-bits that the toggle button needs, the EuiCollapsibleNav component now behaves similar to the EuiPopover component where it accepts abuttonandisOpenprops.It can then also handle the visibility of the button when docked internally.
Checklist
[ ] Checked for breaking changes and labeled appropriately[ ] A changelog entry exists and is marked appropriately