[K8 Nav Feature] Added home and menu glyphs to EuiIcon#3109
Merged
cchaos merged 2 commits intoelastic:feature/collapsible_navfrom Mar 17, 2020
Merged
[K8 Nav Feature] Added home and menu glyphs to EuiIcon#3109cchaos merged 2 commits intoelastic:feature/collapsible_navfrom
home and menu glyphs to EuiIcon#3109cchaos merged 2 commits intoelastic:feature/collapsible_navfrom
Conversation
andreadelrio
approved these changes
Mar 17, 2020
Contributor
andreadelrio
left a comment
There was a problem hiding this comment.
Just one tiny change. Other than that LGTM.
src/components/icon/assets/menu.svg
Outdated
| @@ -0,0 +1,3 @@ | |||
| <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
| <path fill-rule="evenodd" clip-rule="evenodd" d="M0 2H16V4H0V2ZM0 7H16V9H0V7ZM16 12H0V14H16V12Z" /> | |||
Contributor
There was a problem hiding this comment.
Suggested change
| <path fill-rule="evenodd" clip-rule="evenodd" d="M0 2H16V4H0V2ZM0 7H16V9H0V7ZM16 12H0V14H16V12Z" /> | |
| <path d="M0 2H16V4H0V2ZM0 7H16V9H0V7ZM16 12H0V14H16V12Z" /> |
You can remove fill-rule and clip-rule from here.
Contributor
Author
There was a problem hiding this comment.
👍 I think I can remove these without issue. I should update the MD file, but I think we've been seeing some icons that require these in order to display correctly (especially when exported via Figma) so I've generally let them slide recently.
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3109/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3109/ |
cchaos
added a commit
that referenced
this pull request
Mar 18, 2020
cchaos
added a commit
that referenced
this pull request
Mar 26, 2020
cchaos
added a commit
that referenced
this pull request
Mar 27, 2020
* [Feature] Added `EuiCollapsibleNav` component (#2977) * [New Nav Feature] Added `ghost` colored EuiListGroupItem (#3018) * [New Nav Feature] Created `EuiCollapsibleGroup` (#3031) * [New Nav Feature] EuiPinnableListGroup (#3061) * [K8 Nav Feature] Added `home` and `menu` glyphs to EuiIcon (#3109) * [New Nav Feature] Final docs examples and patterns (#3117) * [New Nav Feature] Move collapsible nav toggle button to be part of EuiCollapsibleNav (#3168)
elizabetdev
pushed a commit
to elizabetdev/eui
that referenced
this pull request
Mar 30, 2020
* [Feature] Added `EuiCollapsibleNav` component (elastic#2977) * [New Nav Feature] Added `ghost` colored EuiListGroupItem (elastic#3018) * [New Nav Feature] Created `EuiCollapsibleGroup` (elastic#3031) * [New Nav Feature] EuiPinnableListGroup (elastic#3061) * [K8 Nav Feature] Added `home` and `menu` glyphs to EuiIcon (elastic#3109) * [New Nav Feature] Final docs examples and patterns (elastic#3117) * [New Nav Feature] Move collapsible nav toggle button to be part of EuiCollapsibleNav (elastic#3168)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These new icons will support the header toggle and the home navigation item seen here:
home
menu
Checklist
[ ] Checked in mobile[ ] Props have proper autodocs[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] A changelog entry exists and is marked appropriatelyWill be added by the feature branch