[New Nav Feature] Added ghost colored EuiListGroupItem#3018
Merged
cchaos merged 7 commits intoelastic:feature/collapsible_navfrom Mar 9, 2020
Merged
[New Nav Feature] Added ghost colored EuiListGroupItem#3018cchaos merged 7 commits intoelastic:feature/collapsible_navfrom
ghost colored EuiListGroupItem#3018cchaos merged 7 commits intoelastic:feature/collapsible_navfrom
Conversation
cchaos
commented
Mar 9, 2020
Comment on lines
+32
to
+35
| .euiAccordion__iconWrapper { | ||
| margin-left: $euiSizeS; | ||
| margin-right: $euiSizeXS; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Also includes a quick fix to the PR that included the right-side arrow accordion
added 4 commits
March 9, 2020 16:28
And fixed class names for list group
Fixed color on disabled list group items
bf9ed47 to
bc94df6
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3018/ |
snide
reviewed
Mar 9, 2020
Contributor
snide
left a comment
There was a problem hiding this comment.
Code looks OK. Looks like the subdued example has an issue with focus state
Contributor
Author
Good catch and upon further investigation it looks like it's an issue with the |
andreadelrio
approved these changes
Mar 9, 2020
Contributor
andreadelrio
left a comment
There was a problem hiding this comment.
Changes LGTM but had a question about the ghost example you added to the docs.
added 3 commits
March 9, 2020 17:14
Fixes the hidden underline in focus state
Contributor
Author
|
The issue with the underline on the |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3018/ |
snide
approved these changes
Mar 9, 2020
8 tasks
cchaos
added a commit
that referenced
this pull request
Mar 17, 2020
* Added color=ghost to list group item And fixed class names for list group * Added `color` prop to EuiListGroup Fixed color on disabled list group items * Fixing hover colors for each list item color * ghost example * Increase the height of large items too Fixes the hidden underline in focus state * Fixing demo to not apply black bg to list item * Snaps
cchaos
added a commit
that referenced
this pull request
Mar 18, 2020
* Added color=ghost to list group item And fixed class names for list group * Added `color` prop to EuiListGroup Fixed color on disabled list group items * Fixing hover colors for each list item color * ghost example * Increase the height of large items too Fixes the hidden underline in focus state * Fixing demo to not apply black bg to list item * Snaps
cchaos
added a commit
that referenced
this pull request
Mar 26, 2020
* Added color=ghost to list group item And fixed class names for list group * Added `color` prop to EuiListGroup Fixed color on disabled list group items * Fixing hover colors for each list item color * ghost example * Increase the height of large items too Fixes the hidden underline in focus state * Fixing demo to not apply black bg to list item * Snaps
cchaos
added a commit
that referenced
this pull request
Mar 27, 2020
* [Feature] Added `EuiCollapsibleNav` component (#2977) * [New Nav Feature] Added `ghost` colored EuiListGroupItem (#3018) * [New Nav Feature] Created `EuiCollapsibleGroup` (#3031) * [New Nav Feature] EuiPinnableListGroup (#3061) * [K8 Nav Feature] Added `home` and `menu` glyphs to EuiIcon (#3109) * [New Nav Feature] Final docs examples and patterns (#3117) * [New Nav Feature] Move collapsible nav toggle button to be part of EuiCollapsibleNav (#3168)
elizabetdev
pushed a commit
to elizabetdev/eui
that referenced
this pull request
Mar 30, 2020
* [Feature] Added `EuiCollapsibleNav` component (elastic#2977) * [New Nav Feature] Added `ghost` colored EuiListGroupItem (elastic#3018) * [New Nav Feature] Created `EuiCollapsibleGroup` (elastic#3031) * [New Nav Feature] EuiPinnableListGroup (elastic#3061) * [K8 Nav Feature] Added `home` and `menu` glyphs to EuiIcon (elastic#3109) * [New Nav Feature] Final docs examples and patterns (elastic#3117) * [New Nav Feature] Move collapsible nav toggle button to be part of EuiCollapsibleNav (elastic#3168)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds one more option to EuiListGroupItem for color
which is
ghost, for use when the list is on a dark background as will be needed like in this screenshot:Also, adds the option for EuiListGroup to pass the
coloroption to every list itemTypically you'd only be able to color each list item, but now you color all of them if you're passing items via the
listItemsprop object.Checklist
[ ] Checked in mobile[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes[ ] A changelog entry exists and is marked appropriatelyWill get added via feature branch