x-pack/plugin/apm: introduce x-pack-apm plugin#97546
Conversation
|
How do we ensure rollovers when settings or mappings change? Does this PR depend on #96521? |
|
@felixbarny we don't. We would either need #96521, or do it in the plugin:
😄 |
x-pack/plugin/apm/src/main/resources/index-templates/metrics-apm.app.yaml
Outdated
Show resolved
Hide resolved
|
@danielmitterdorfer provided some helpful pointers on Slack: #97380 adds support for upgrading Universal Profiling data streams and indices. Maybe we can take some inspiration from there to address #96521? #97773 adds support for migrations. I haven't looked at all the details, but perhaps this could be useful for adding runtime fields to old backing indices for schema evolution. |
...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/template/IngestPipelineConfig.java
Outdated
Show resolved
Hide resolved
...k/plugin/core/src/main/java/org/elasticsearch/xpack/core/template/IndexTemplateRegistry.java
Show resolved
Hide resolved
|
@jbaiera I addressed all review comments. As agreed with @axw and @felixbarny, full integration tests for APM components will be added in a followup effort. I removed the rollover test from the APM data plugin and added a simple one that tests the basic functionality to core instead. |
jbaiera
left a comment
There was a problem hiding this comment.
Thanks for iterating on this! Given that the index template registry refactoring is on the todo list for future consideration, I think things look good to me!
|
Thank you for finishing this up @eyalkoren, and for your support @jbaiera! ❤️ |
Introduce the
x-pack-apmplugin, which installs index templates, component templates, and ingest pipelines for Elastic APM.This replaces the need for installing any Fleet integration package for Elastic APM, unless central configuration/fleet management is desired, simplifying setup for users of the apm-server binary. This will also simplify APM Server by removing the possibility of index templates being missing on startup.