[Profiling] Add initial support for upgrades#97380
Merged
danielmitterdorfer merged 7 commits intoelastic:mainfrom Jul 6, 2023
Merged
[Profiling] Add initial support for upgrades#97380danielmitterdorfer merged 7 commits intoelastic:mainfrom
danielmitterdorfer merged 7 commits intoelastic:mainfrom
Conversation
With this commit we add support to specify upgrade behavior per index (or data stream) that is managed by the profiling plugin: * Data streams and K/V indices will be rolled over: The prior write index will remain untouched and eventually be deleted according to the ILM policy. * Regular indices may either be ignored or deleted on upgrades.
Collaborator
|
Hi @danielmitterdorfer, I've created a changelog YAML for you. |
Collaborator
|
Pinging @elastic/profiling (Team:Universal Profiling) |
Member
Author
|
The build scan shows: This is definitely unrelated to this PR and may be transient so I'm retriggering the build. There are a couple of closed issues that are somewhat related but that problem seems new. @elasticsearchmachine run elasticsearch-ci/part-2 |
rockdaboot
reviewed
Jul 5, 2023
...iler/src/main/java/org/elasticsearch/xpack/profiler/AbstractProfilingPersistenceManager.java
Outdated
Show resolved
Hide resolved
rockdaboot
reviewed
Jul 5, 2023
...iler/src/main/java/org/elasticsearch/xpack/profiler/AbstractProfilingPersistenceManager.java
Outdated
Show resolved
Hide resolved
rockdaboot
reviewed
Jul 5, 2023
...iler/src/main/java/org/elasticsearch/xpack/profiler/AbstractProfilingPersistenceManager.java
Outdated
Show resolved
Hide resolved
rockdaboot
reviewed
Jul 5, 2023
| new ActionListener<RolloverResponse>() { | ||
| @Override | ||
| public void onResponse(RolloverResponse response) { | ||
| if (response.isAcknowledged() == false) { |
Contributor
There was a problem hiding this comment.
just for readability: is it possible to move the logging code into a separate function, e.g. logResponseStatus(...) ? Same for rolloverIndex() in ProfilingIndexManager.
rockdaboot
reviewed
Jul 5, 2023
...ck/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/ProfilingIndexManager.java
Show resolved
Hide resolved
rockdaboot
reviewed
Jul 5, 2023
...ck/plugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/ProfilingIndexManager.java
Show resolved
Hide resolved
rockdaboot
reviewed
Jul 5, 2023
...ugin/profiler/src/main/java/org/elasticsearch/xpack/profiler/ProfilingDataStreamManager.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this commit we add support to specify upgrade behavior per index (or data stream) that is managed by the profiling plugin: