Fix createComponents signature in APM-Data plugin#101578
Merged
tvernum merged 1 commit intoelastic:mainfrom Oct 31, 2023
Merged
Fix createComponents signature in APM-Data plugin#101578tvernum merged 1 commit intoelastic:mainfrom
tvernum merged 1 commit intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
axw
approved these changes
Oct 31, 2023
tvernum
commented
Oct 31, 2023
| private final SetOnce<APMIndexTemplateRegistry> registry = new SetOnce<>(); | ||
|
|
||
| public APMPlugin(Settings settings) { | ||
| this.settings = settings; |
Contributor
Author
There was a problem hiding this comment.
I dropped this because it's actually a bug. The settings object that's passed in the constructor should only ever be used in the constructor - everything later in the lifecycle should use the settings from environment.
Contributor
Author
|
I'm going to merge before CI completes as the PR is reviewed & the build is currently broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates: #97546, #101305