Better support for multi cluster for run task#89442
Merged
jakelandis merged 3 commits intoelastic:mainfrom Aug 18, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
approved these changes
Aug 18, 2022
Contributor
mark-vieira
left a comment
There was a problem hiding this comment.
Multi-cluster configuration with the run task in indeed quite awkward. We could improve this but this is probably fine for now given it's pretty self-contained.
Contributor
Author
|
Thanks Mark ! |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Aug 19, 2022
* upstream/main: (265 commits) Disable openid connect tests due to missing fixture (elastic#89478) Add periodic job for single processor node testing Updates to changelog processing after docs redesign (elastic#89463) Better support for multi cluster for run task (elastic#89442) Mute failing tests (elastic#89465) [ML] Performance improvements related to ECS Grok pattern usage (elastic#89424) Add source fallback support for date and date_nanos mapped types (elastic#89440) Reuse Info in lifecycle step (elastic#89419) feature: support metrics for multi value fields (elastic#88818) Upgrade OpenTelemetry API and remove workaround (elastic#89438) Remove LegacyClusterTaskResultActionListener (elastic#89459) Add YAML spec docs about matching errors (elastic#89370) Remove redundant cluster upgrade tests for auth tokens (elastic#89417) Return 400 error for GetUserPrivileges call with API keys (elastic#89333) User Profile - Detailed errors in hasPrivileges response (elastic#89224) Rollover min_* conditions docs and highlight (elastic#89434) REST tests for percentiles_bucket agg (elastic#88029) REST tests for cumulative pipeline aggs (elastic#88966) Clean-up file watcher keys. (elastic#89429) fix a typo in Security.java (elastic#89248) ... # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/NumberFieldMapper.java
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Aug 24, 2022
This reverts commit 20ed7e3.
Closed
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Aug 29, 2022
This reverts commit 20ed7e3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a
./gradlew run-ccstask with the following goals:./gradlew runfor manual cross cluster search developmentThis is admittedly kinda hacky. Test clusters have support multi-cluster and are in use for
for automated testing. There are some nuances that make that setup (and this setup)
a bit cumbersome..specifically needing to read one cluster's config to configure another cluster.
The run task adds a bit more config (well defined ports, etc.) than the tests need to
so that also complicates this abit more. I found that without the additions here I was unable to get both
sharing of cluster configuration (like in the tests)
and the run task's hard coded config to work well together. Hopefully the additions to the run task are not
too hacky as I could not find any other way.
===
Also FWIW, this is in support of a new security model for CCS and CCR so there will likely
be more PR's with multi-cluster configs to help testing that effort.