Reuse Info in lifecycle step#89419
Merged
elasticsearchmachine merged 5 commits intoelastic:mainfrom Aug 18, 2022
Merged
Conversation
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
dakrone
approved these changes
Aug 17, 2022
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, I saw one typo in the changelog
Member
|
@elasticmachine ok to test |
dakrone
requested changes
Aug 17, 2022
Member
dakrone
left a comment
There was a problem hiding this comment.
It appears that this also needs test changes (see the CI failures for details), as a lot of them reference the inner Info classes, @mushao999 can you adjust this accordingly?
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
dakrone
approved these changes
Aug 18, 2022
Member
|
@elasticmachine update branch |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Aug 19, 2022
* upstream/main: (265 commits) Disable openid connect tests due to missing fixture (elastic#89478) Add periodic job for single processor node testing Updates to changelog processing after docs redesign (elastic#89463) Better support for multi cluster for run task (elastic#89442) Mute failing tests (elastic#89465) [ML] Performance improvements related to ECS Grok pattern usage (elastic#89424) Add source fallback support for date and date_nanos mapped types (elastic#89440) Reuse Info in lifecycle step (elastic#89419) feature: support metrics for multi value fields (elastic#88818) Upgrade OpenTelemetry API and remove workaround (elastic#89438) Remove LegacyClusterTaskResultActionListener (elastic#89459) Add YAML spec docs about matching errors (elastic#89370) Remove redundant cluster upgrade tests for auth tokens (elastic#89417) Return 400 error for GetUserPrivileges call with API keys (elastic#89333) User Profile - Detailed errors in hasPrivileges response (elastic#89224) Rollover min_* conditions docs and highlight (elastic#89434) REST tests for percentiles_bucket agg (elastic#88029) REST tests for cumulative pipeline aggs (elastic#88966) Clean-up file watcher keys. (elastic#89429) fix a typo in Security.java (elastic#89248) ... # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/NumberFieldMapper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a
SingleMessageFiledInfodefined inorg/elasticsearch/xpack/core/ilm/step/infoto provide single message info forAsyncWaitStepandClusterStateWaitStep.But there are still some steps likeCheckNotDataStreamWriteIndexStepdefining their own single message info.This pr removes the duplicated info defination in these steps and use
SingleMessageFiledInfoinstand.