User Profile - Detailed errors in hasPrivileges response#89224
Merged
elasticsearchmachine merged 5 commits intoelastic:mainfrom Aug 18, 2022
Merged
Conversation
This PR adds a new `errors` field in the ProfilehasPrivileges response to report detailed errors encountered, including missing UIDs. It also removes the existing `errors_uids` field since this is redundant after the change.
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
Collaborator
|
Hi @ywangd, I've created a changelog YAML for you. |
ywangd
commented
Aug 10, 2022
Comment on lines
+52
to
+53
| // Only compare the keys (profile uids) of the errors, actual error types do not matter | ||
| return hasPrivilegeUids.equals(that.hasPrivilegeUids) && errors.keySet().equals(that.errors.keySet()); |
Member
Author
There was a problem hiding this comment.
There is no good way to compare Exception objects. Since equals and hashCode are only used in tests (ProfileHasPrivilegesResponseTests), I took a simple approach to just compare the erroneous profile uids.
Member
Author
|
@azasypkin This is the PR for adding detailed errors to the ProfileHasPrivileges API response. @elastic/clients-team This PR drops an existing |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-2-fips |
azasypkin
approved these changes
Aug 17, 2022
Contributor
azasypkin
left a comment
There was a problem hiding this comment.
LGTM from the Kibana side, thanks!
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-2 |
Member
Author
|
Failure is unrelated and tracked at #89431 |
Member
Author
|
@elasticmachine run elasticsearch-ci/part-1-fips |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Aug 19, 2022
* upstream/main: (265 commits) Disable openid connect tests due to missing fixture (elastic#89478) Add periodic job for single processor node testing Updates to changelog processing after docs redesign (elastic#89463) Better support for multi cluster for run task (elastic#89442) Mute failing tests (elastic#89465) [ML] Performance improvements related to ECS Grok pattern usage (elastic#89424) Add source fallback support for date and date_nanos mapped types (elastic#89440) Reuse Info in lifecycle step (elastic#89419) feature: support metrics for multi value fields (elastic#88818) Upgrade OpenTelemetry API and remove workaround (elastic#89438) Remove LegacyClusterTaskResultActionListener (elastic#89459) Add YAML spec docs about matching errors (elastic#89370) Remove redundant cluster upgrade tests for auth tokens (elastic#89417) Return 400 error for GetUserPrivileges call with API keys (elastic#89333) User Profile - Detailed errors in hasPrivileges response (elastic#89224) Rollover min_* conditions docs and highlight (elastic#89434) REST tests for percentiles_bucket agg (elastic#88029) REST tests for cumulative pipeline aggs (elastic#88966) Clean-up file watcher keys. (elastic#89429) fix a typo in Security.java (elastic#89248) ... # Conflicts: # server/src/main/java/org/elasticsearch/index/mapper/NumberFieldMapper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
errorsfield in the ProfilehasPrivileges responseto report detailed errors encountered, including missing UIDs. It also
removes the existing
errors_uidsfield since this is redundant afterthe change.