Skip to content

Fix double rounding errors for disk usage#88683

Merged
kingherc merged 1 commit intoelastic:masterfrom
kingherc:bugfix/fix-disk-usage-rounding
Jul 21, 2022
Merged

Fix double rounding errors for disk usage#88683
kingherc merged 1 commit intoelastic:masterfrom
kingherc:bugfix/fix-disk-usage-rounding

Conversation

@kingherc
Copy link
Copy Markdown
Contributor

Fix double rounding errors for disk usage

Copy link
Copy Markdown
Member

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added >non-issue :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels Jul 21, 2022
@kingherc kingherc marked this pull request as ready for review July 21, 2022 13:39
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team. label Jul 21, 2022
@kingherc
Copy link
Copy Markdown
Contributor Author

LGTM

@DaveCTurner you're quick :D thanks! Will try to see if I can carve out more PRs

@kingherc
Copy link
Copy Markdown
Contributor Author

Oh as a non-issue, it does not need a changelog YAML. Will just merge it then.

@kingherc kingherc merged commit 8996fd0 into elastic:master Jul 21, 2022
@DaveCTurner
Copy link
Copy Markdown
Member

++ yes sorry I thought @elasticmachine was just being slow. I'm pretty sure this is a non-issue anyway, it's definitely true that a*(b*c) != (a*b)*c for doubles but I don't think they're meaningfully different here.

weizijun added a commit to weizijun/elasticsearch that referenced this pull request Jul 22, 2022
* upstream/master: (40 commits)
  Fix CI job naming
  [ML] disallow autoscaling downscaling in two trained model assignment scenarios (elastic#88623)
  Add "Vector Search" area to changelog schema
  [DOCS] Update API key API (elastic#88499)
  Enable the pipeline on the feature branch (elastic#88672)
  Adding the ability to register a PeerFinderListener to Coordinator (elastic#88626)
  [DOCS] Fix transform painless example syntax (elastic#88364)
  [ML] Muting InternalCategorizationAggregationTests testReduceRandom (elastic#88685)
  Fix double rounding errors for disk usage (elastic#88683)
  Replace health request with a state observer. (elastic#88641)
  [ML] Fail model deployment if all allocations cannot be provided (elastic#88656)
  Upgrade to OpenJDK 18.0.2+9 (elastic#88675)
  [ML] make bucket_correlation aggregation generally available (elastic#88655)
  Adding cardinality support for random_sampler agg (elastic#86838)
  Use custom task instead of generic AckedClusterStateUpdateTask (elastic#88643)
  Reinstate test cluster throttling behavior (elastic#88664)
  Mute testReadBlobWithPrematureConnectionClose
  Simplify plugin descriptor tests (elastic#88659)
  Add CI job for testing more job parallelism
  [ML] make deployment infer requests fully cancellable (elastic#88649)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue Team:Distributed Meta label for distributed team. v8.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants