Use custom task instead of generic AckedClusterStateUpdateTask#88643
Merged
idegtiarenko merged 2 commits intoelastic:masterfrom Jul 21, 2022
Merged
Conversation
…s not intended to be used with batching.
DaveCTurner
reviewed
Jul 20, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Looks good, I left a couple of (debatable) suggestions.
| } | ||
|
|
||
| if (skippedSettings.isEmpty() == false && openIndices.isEmpty() == false) { | ||
| throw new IllegalArgumentException( |
Member
There was a problem hiding this comment.
I think we can still throw here...
| indicesService.verifyIndexMetadata(updatedMetadata, updatedMetadata); | ||
| } | ||
| } catch (IOException ex) { | ||
| throw ExceptionsHelper.convertToElastic(ex); |
Member
There was a problem hiding this comment.
... and here. Then we don't need to pass in the taskContext.
| assert false : "should not be called"; | ||
| } | ||
|
|
||
| private ClusterStateAckListener getAckListener() { |
Member
There was a problem hiding this comment.
Typically ack-sensitive tasks implement ClusterStateAckListener themselves rather than creating a new object. Not that it really matters, just a question of harmony with other implementations.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
16 tasks
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jul 22, 2022
* upstream/master: (40 commits) Fix CI job naming [ML] disallow autoscaling downscaling in two trained model assignment scenarios (elastic#88623) Add "Vector Search" area to changelog schema [DOCS] Update API key API (elastic#88499) Enable the pipeline on the feature branch (elastic#88672) Adding the ability to register a PeerFinderListener to Coordinator (elastic#88626) [DOCS] Fix transform painless example syntax (elastic#88364) [ML] Muting InternalCategorizationAggregationTests testReduceRandom (elastic#88685) Fix double rounding errors for disk usage (elastic#88683) Replace health request with a state observer. (elastic#88641) [ML] Fail model deployment if all allocations cannot be provided (elastic#88656) Upgrade to OpenJDK 18.0.2+9 (elastic#88675) [ML] make bucket_correlation aggregation generally available (elastic#88655) Adding cardinality support for random_sampler agg (elastic#86838) Use custom task instead of generic AckedClusterStateUpdateTask (elastic#88643) Reinstate test cluster throttling behavior (elastic#88664) Mute testReadBlobWithPrematureConnectionClose Simplify plugin descriptor tests (elastic#88659) Add CI job for testing more job parallelism [ML] make deployment infer requests fully cancellable (elastic#88649) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use custom task instead of generic AckedClusterStateUpdateTask that is not intended to be used with batching.