Adding the ability to register a PeerFinderListener to Coordinator#88626
Merged
masseyke merged 3 commits intoelastic:masterfrom Jul 21, 2022
Merged
Adding the ability to register a PeerFinderListener to Coordinator#88626masseyke merged 3 commits intoelastic:masterfrom
masseyke merged 3 commits intoelastic:masterfrom
Conversation
Member
Author
|
One question I have is whether this is granular enough. For example, when a master node steps down and a new one is elected,
For #88562 I only care about the first one. It's possible the others could have uses too. |
Member
Author
|
@DaveCTurner does this look like what you had in mind when we talked? |
DaveCTurner
approved these changes
Jul 21, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Sure, makes sense. LGTM (one nit)
| } | ||
|
|
||
| void onFoundPeersUpdated() { | ||
| public void onFoundPeersUpdated() { |
Member
There was a problem hiding this comment.
Suggested change
| public void onFoundPeersUpdated() { | |
| @Override | |
| public void onFoundPeersUpdated() { |
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Collaborator
|
Hi @masseyke, I've created a changelog YAML for you. |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Jul 22, 2022
* upstream/master: (40 commits) Fix CI job naming [ML] disallow autoscaling downscaling in two trained model assignment scenarios (elastic#88623) Add "Vector Search" area to changelog schema [DOCS] Update API key API (elastic#88499) Enable the pipeline on the feature branch (elastic#88672) Adding the ability to register a PeerFinderListener to Coordinator (elastic#88626) [DOCS] Fix transform painless example syntax (elastic#88364) [ML] Muting InternalCategorizationAggregationTests testReduceRandom (elastic#88685) Fix double rounding errors for disk usage (elastic#88683) Replace health request with a state observer. (elastic#88641) [ML] Fail model deployment if all allocations cannot be provided (elastic#88656) Upgrade to OpenJDK 18.0.2+9 (elastic#88675) [ML] make bucket_correlation aggregation generally available (elastic#88655) Adding cardinality support for random_sampler agg (elastic#86838) Use custom task instead of generic AckedClusterStateUpdateTask (elastic#88643) Reinstate test cluster throttling behavior (elastic#88664) Mute testReadBlobWithPrematureConnectionClose Simplify plugin descriptor tests (elastic#88659) Add CI job for testing more job parallelism [ML] make deployment infer requests fully cancellable (elastic#88649) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came out of #88562. The problem there is that if we are a non-master-eligible node we want to start polling a master-eligible node whenever we realize that there is no elected master. We are notified that there is no elected master in a
ClusterChangedEvent. We get the list of master-eligible nodes fromPeerFinder#getFoundPeers. However at that the time that we are notified of theClusterChangeEvent,PeerFinder#getFoundPeersreturns an emptyIterable. That collection is populated in another thread, and there is currently no way to get notified of when it is populated. This PR adds the ability to register aPeerFinderListenerwithCoordinator. The listener has anonFoundPeersUpdatedthat is called whenever the collection of peers changes (whether added to or removed from).