TSDB: Make time boundaries settings required in tsdb indices#81146
Merged
nik9000 merged 12 commits intoelastic:masterfrom Dec 1, 2021
Merged
TSDB: Make time boundaries settings required in tsdb indices#81146nik9000 merged 12 commits intoelastic:masterfrom
nik9000 merged 12 commits intoelastic:masterfrom
Conversation
* upstream/master: (29 commits) Fix typo (elastic#80925) Increase docker compose timeouts for CI builds TSDB: fix error without feature flag (elastic#80945) [DOCS] Relocate `index.mapping.dimension_fields.limit` setting docs (elastic#80964) Explicit write methods for always-missing values (elastic#80958) TSDB: move TimeSeriesModeIT to yaml tests (elastic#80933) [ML] Removing temporary debug (elastic#80956) Remove unused ConnectTransportException#node (elastic#80944) Reinterpret dots in field names as object structure (elastic#79922) Remove obsolete typed legacy index templates (elastic#80937) Remove unnecessary shuffle in unassigned shards allocation. (elastic#65172) TSDB: Tests for nanosecond timeprecision timestamp just beyond the limit (elastic#80932) Cleanup SLM History Item .equals (elastic#80938) Rework breaking changes for new structure (elastic#80907) [DOCS] Fix elasticsearch-reset-password typo (elastic#80919) [ML] No need to use parent task client when internal infer delegates (elastic#80905) Fix shadowed vars pt6 (elastic#80899) add ignore info (elastic#80924) Fix several potential circuit breaker leaks in Aggregators (elastic#79676) Extract more standard metadata from binary files (elastic#78754) ...
* upstream/master: (55 commits) Fix ComposableIndexTemplate equals when composed_of is null (elastic#80864) Optimize DLS bitset building for matchAll query (elastic#81030) URL option for BaseRunAsSuperuserCommand (elastic#81025) Less Verbose Serialization of Snapshot Failure in SLM Metadata (elastic#80942) Fix shadowed vars pt7 (elastic#80996) Fail shards early when we can detect a type missmatch (elastic#79869) Delegate Ref Counting to ByteBuf in Netty Transport (elastic#81096) Clarify `unassigned.reason` docs (elastic#81017) Strip blocks from settings for reindex targets (elastic#80887) Split off the values supplier for ScriptDocValues (elastic#80635) [ML] Switch message and detail for model snapshot deprecations (elastic#81108) [DOCS] Update xrefs for snapshot restore docs (elastic#81023) [ML] Updates visiblity of validate API (elastic#81061) Track histogram of transport handling times (elastic#80581) [ML] Fix datafeed preview with remote indices (elastic#81099) [ML] Fix acceptable model snapshot versions in ML deprecation checker (elastic#81060) [ML] Add logging for failing PyTorch test (elastic#81044) Extending the timeout waiting for snapshot to be ready (elastic#81018) [ML] Fix incorrect logging of unexpected model size error (elastic#81089) [ML] Make inference timeout test more reliable (elastic#81094) ...
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
reviewed
Nov 30, 2021
Member
nik9000
left a comment
There was a problem hiding this comment.
I think it'd be nice to use times in the tests that are a little closer to the test data. If we're really make truly random times from 1 to Long.MAX_VALUE it's cool to have those as bounds, but for the tests I'd feel better with bounds that are a day or a month long or something like that.
| routing_path: [metricset] | ||
| time_series: | ||
| start_time: 1 | ||
| end_time: 253402300799998 |
Member
There was a problem hiding this comment.
I think it'd be nice to have something a little more realistic here - probably jut 2021-04-28T00:00:00Z to 2021-04-29 or something like that.
Member
|
@elasticmachine, test this please |
* upstream/master: [ML] Parent datafeed actions to the datafeed's persistent task (elastic#81143) Simplify ConcreteIndices and its usage in TransportBulkAction (elastic#81098) Unmute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test (elastic#81142) TSDB: Do not allow index splits for time series indices (elastic#81125) Reduce verbosity-increase timeout to 3m (elastic#81118) Mute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test Fix stopping of old elasticsearch cluster (elastic#81059) Fix data stream alias validation. (elastic#81040) Add replicated field to get data stream api response. (elastic#80988)
nik9000
reviewed
Nov 30, 2021
rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/tsdb/60_add_dimensions.yml
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@nik9000 can I change all tsdb yaml test's skip config from: to to pass the mixed-cluster tests |
Member
👍 |
Member
|
@elasticmachine, test this please |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@nik9000 I have passed all check. can you help to merge the PR? |
Member
|
@elasticmachine, test this please |
Contributor
Author
|
@nik9000 the failed elasticsearch-ci/release-tests seems that the problem of the environment |
Member
|
run elasticsearch-ci/release-tests |
Member
👍. Let's see if it's better a second time. |
Member
|
run elasticsearch-ci/release-tests |
Member
|
@elasticmachine, update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
index.time_series.start_timeandindex.time_series.end_timesettings as required settings in tsdb indices.It will change many tests, among which a time_series index is created, and it will add the
index.time_series.start_timeandindex.time_series.end_timesettings