Merged
Conversation
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
Collaborator
|
Pinging @elastic/clients-team (Team:Clients) |
Contributor
|
(The ping for clients team can be ignored, was triggered by modifying |
mark-vieira
approved these changes
Nov 22, 2021
| public long getTotalSpace() throws IOException { | ||
| final long totalSpace = this.totalSpace; | ||
| if (totalSpace == -1) { | ||
| final long totalSpaceCopy = this.totalSpace; |
Contributor
There was a problem hiding this comment.
I don't quite see the point is creating this intermediate variable in the first place.
Contributor
Author
There was a problem hiding this comment.
It's a volatile variable, I assume the copy is something to do with that.
pugnascotia
added a commit
that referenced
this pull request
Nov 23, 2021
Part of #19752. Fix more instances where local variable names were shadowing field names.
pugnascotia
added a commit
to pugnascotia/elasticsearch
that referenced
this pull request
Nov 23, 2021
Part of elastic#19752. Fix more instances where local variable names were shadowing field names.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 23, 2021
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Nov 23, 2021
* upstream/master: Cleanup SLM History Item .equals (elastic#80938) Rework breaking changes for new structure (elastic#80907) [DOCS] Fix elasticsearch-reset-password typo (elastic#80919) [ML] No need to use parent task client when internal infer delegates (elastic#80905) Fix shadowed vars pt6 (elastic#80899) add ignore info (elastic#80924) Fix several potential circuit breaker leaks in Aggregators (elastic#79676) # Conflicts: # server/src/internalClusterTest/java/org/elasticsearch/index/TimeSeriesModeIT.java
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Nov 24, 2021
* upstream/master: (29 commits) Fix typo (elastic#80925) Increase docker compose timeouts for CI builds TSDB: fix error without feature flag (elastic#80945) [DOCS] Relocate `index.mapping.dimension_fields.limit` setting docs (elastic#80964) Explicit write methods for always-missing values (elastic#80958) TSDB: move TimeSeriesModeIT to yaml tests (elastic#80933) [ML] Removing temporary debug (elastic#80956) Remove unused ConnectTransportException#node (elastic#80944) Reinterpret dots in field names as object structure (elastic#79922) Remove obsolete typed legacy index templates (elastic#80937) Remove unnecessary shuffle in unassigned shards allocation. (elastic#65172) TSDB: Tests for nanosecond timeprecision timestamp just beyond the limit (elastic#80932) Cleanup SLM History Item .equals (elastic#80938) Rework breaking changes for new structure (elastic#80907) [DOCS] Fix elasticsearch-reset-password typo (elastic#80919) [ML] No need to use parent task client when internal infer delegates (elastic#80905) Fix shadowed vars pt6 (elastic#80899) add ignore info (elastic#80924) Fix several potential circuit breaker leaks in Aggregators (elastic#79676) Extract more standard metadata from binary files (elastic#78754) ...
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Nov 24, 2021
* upstream/master: (319 commits) Fix typo (elastic#80925) Increase docker compose timeouts for CI builds TSDB: fix error without feature flag (elastic#80945) [DOCS] Relocate `index.mapping.dimension_fields.limit` setting docs (elastic#80964) Explicit write methods for always-missing values (elastic#80958) TSDB: move TimeSeriesModeIT to yaml tests (elastic#80933) [ML] Removing temporary debug (elastic#80956) Remove unused ConnectTransportException#node (elastic#80944) Reinterpret dots in field names as object structure (elastic#79922) Remove obsolete typed legacy index templates (elastic#80937) Remove unnecessary shuffle in unassigned shards allocation. (elastic#65172) TSDB: Tests for nanosecond timeprecision timestamp just beyond the limit (elastic#80932) Cleanup SLM History Item .equals (elastic#80938) Rework breaking changes for new structure (elastic#80907) [DOCS] Fix elasticsearch-reset-password typo (elastic#80919) [ML] No need to use parent task client when internal infer delegates (elastic#80905) Fix shadowed vars pt6 (elastic#80899) add ignore info (elastic#80924) Fix several potential circuit breaker leaks in Aggregators (elastic#79676) Extract more standard metadata from binary files (elastic#78754) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #19752. Fix more instances where local variable names were shadowing field names.