Fix data stream alias validation.#81040
Merged
martijnvg merged 3 commits intoelastic:masterfrom Nov 30, 2021
Merged
Conversation
328b22f to
8e54116
Compare
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
41fcfa5 to
36dd4e6
Compare
In case of restoring a snapshot, it is possible to overwrite an existing data stream with a data stream alias from a snapshot. This change fixes this by improving the generic duplicate name validation. On top of this the lack of data stream alias validation in Metadata.Builder#build() method resulted in cases where data stream aliases could be added for existing index aliases, data streams or indices with the same name. Closes elastic#80972
36dd4e6 to
e4793d4
Compare
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 30, 2021
In case of restoring a snapshot, it is possible to overwrite an existing data stream with a data stream alias from a snapshot. This change fixes this by improving the generic duplicate name validation. On top of this the lack of data stream alias validation in Metadata.Builder#build() method resulted in cases where data stream aliases could be added for existing index aliases, data streams or indices with the same name. Closes elastic#80972
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 30, 2021
In case of restoring a snapshot, it is possible to overwrite an existing data stream with a data stream alias from a snapshot. This change fixes this by improving the generic duplicate name validation. On top of this the lack of data stream alias validation in Metadata.Builder#build() method resulted in cases where data stream aliases could be added for existing index aliases, data streams or indices with the same name. Closes elastic#80972
Collaborator
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 30, 2021
…ngIndicesAlias() test and fix the test problem, which is that testRestoreDataStreamAliasWithConflictingDataStream() test needs to remove the composable index template that it adds. The base test class doesn't remove any composable index templates and this template interferes with the testRestoreDataStreamAliasWithConflictingIndicesAlias() test. Relates to elastic#81040
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 30, 2021
…ngIndicesAlias() test and fix the test problem, which is that testRestoreDataStreamAliasWithConflictingDataStream() test needs to remove the composable index template that it adds. The base test class doesn't remove any composable index templates and this template interferes with the testRestoreDataStreamAliasWithConflictingIndicesAlias() test. Relates to elastic#81040
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 30, 2021
…ngIndicesAlias() test and fix the test problem, which is that testRestoreDataStreamAliasWithConflictingDataStream() test needs to remove the composable index template that it adds. The base test class doesn't remove any composable index templates and this template interferes with the testRestoreDataStreamAliasWithConflictingIndicesAlias() test. Relates to elastic#81040
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Fix data stream alias validation. (#81040) In case of restoring a snapshot, it is possible to overwrite an existing data stream with a data stream alias from a snapshot. This change fixes this by improving the generic duplicate name validation. On top of this the lack of data stream alias validation in Metadata.Builder#build() method resulted in cases where data stream aliases could be added for existing index aliases, data streams or indices with the same name. Closes #80972 * adjust to 7.16 reality * Unmute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test and fix the test problem, which is that testRestoreDataStreamAliasWithConflictingDataStream() test needs to remove the composable index template that it adds. The base test class doesn't remove any composable index templates and this template interferes with the testRestoreDataStreamAliasWithConflictingIndicesAlias() test. Relates to #81040
martijnvg
added a commit
that referenced
this pull request
Nov 30, 2021
…ngIndicesAlias() test (#81142) and fix the test problem, which is that testRestoreDataStreamAliasWithConflictingDataStream() test needs to remove the composable index template that it adds. The base test class doesn't remove any composable index templates and this template interferes with the testRestoreDataStreamAliasWithConflictingIndicesAlias() test. Relates to #81040
elasticsearchmachine
pushed a commit
that referenced
this pull request
Nov 30, 2021
* Fix data stream alias validation. (#81040) In case of restoring a snapshot, it is possible to overwrite an existing data stream with a data stream alias from a snapshot. This change fixes this by improving the generic duplicate name validation. On top of this the lack of data stream alias validation in Metadata.Builder#build() method resulted in cases where data stream aliases could be added for existing index aliases, data streams or indices with the same name. Closes #80972 * Unmute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test and fix the test problem, which is that testRestoreDataStreamAliasWithConflictingDataStream() test needs to remove the composable index template that it adds. The base test class doesn't remove any composable index templates and this template interferes with the testRestoreDataStreamAliasWithConflictingIndicesAlias() test. Relates to #81040
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Nov 30, 2021
* upstream/master: [ML] Parent datafeed actions to the datafeed's persistent task (elastic#81143) Simplify ConcreteIndices and its usage in TransportBulkAction (elastic#81098) Unmute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test (elastic#81142) TSDB: Do not allow index splits for time series indices (elastic#81125) Reduce verbosity-increase timeout to 3m (elastic#81118) Mute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test Fix stopping of old elasticsearch cluster (elastic#81059) Fix data stream alias validation. (elastic#81040) Add replicated field to get data stream api response. (elastic#80988)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of restoring a snapshot, it is possible to overwrite an existing
data stream with a data stream alias from a snapshot. This change fixes
this by improving the generic duplicate name validation.
On top of this the lack of data stream alias validation in Metadata.Builder#build()
method resulted in cases where data stream aliases could be added for existing
index aliases, data streams or indices with the same name.
Closes #80972