[8.0] Fix data stream alias validation. (#81040)#81135
Merged
elasticsearchmachine merged 2 commits intoelastic:8.0from Nov 30, 2021
Merged
[8.0] Fix data stream alias validation. (#81040)#81135elasticsearchmachine merged 2 commits intoelastic:8.0from
elasticsearchmachine merged 2 commits intoelastic:8.0from
Conversation
In case of restoring a snapshot, it is possible to overwrite an existing data stream with a data stream alias from a snapshot. This change fixes this by improving the generic duplicate name validation. On top of this the lack of data stream alias validation in Metadata.Builder#build() method resulted in cases where data stream aliases could be added for existing index aliases, data streams or indices with the same name. Closes elastic#80972
…ngIndicesAlias() test and fix the test problem, which is that testRestoreDataStreamAliasWithConflictingDataStream() test needs to remove the composable index template that it adds. The base test class doesn't remove any composable index templates and this template interferes with the testRestoreDataStreamAliasWithConflictingIndicesAlias() test. Relates to elastic#81040
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 8.0: