Skip to content

TSDB: Do not allow index splits for time series indices#81125

Merged
csoulios merged 4 commits intoelastic:masterfrom
csoulios:tsdb-index-split
Nov 30, 2021
Merged

TSDB: Do not allow index splits for time series indices#81125
csoulios merged 4 commits intoelastic:masterfrom
csoulios:tsdb-index-split

Conversation

@csoulios
Copy link
Copy Markdown
Contributor

@csoulios csoulios commented Nov 29, 2021

Index _split operation may have some issues with time series indices, as
the splits must respect and adjust the time boundaries.

This PR forbids users to execute the split operation on time series indices,
until we revisit this approach in the future.

@csoulios csoulios added :StorageEngine/TSDB You know, for Metrics v8.1.0 labels Nov 29, 2021
@csoulios csoulios requested a review from nik9000 November 29, 2021 20:14
@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 29, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

listener.onFailure(e);
return;
}
}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like the cleanest way to do it but it makes sense given what we have. And I don't think its permanent.

instead of delegating it to the ActionListener
@csoulios
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@csoulios
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/part-2

@csoulios csoulios merged commit 63d710d into elastic:master Nov 30, 2021
@csoulios csoulios deleted the tsdb-index-split branch November 30, 2021 10:08
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Nov 30, 2021
* upstream/master:
  [ML] Parent datafeed actions to the datafeed's persistent task (elastic#81143)
  Simplify ConcreteIndices and its usage in TransportBulkAction (elastic#81098)
  Unmute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test (elastic#81142)
  TSDB: Do not allow index splits for time series indices (elastic#81125)
  Reduce verbosity-increase timeout to 3m (elastic#81118)
  Mute DataStreamsSnapshotsIT#testRestoreDataStreamAliasWithConflictingIndicesAlias() test
  Fix stopping of old elasticsearch cluster (elastic#81059)
  Fix data stream alias validation. (elastic#81040)
  Add replicated field to get data stream api response. (elastic#80988)
@wchaparro wchaparro assigned csoulios and unassigned csoulios Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :StorageEngine/TSDB You know, for Metrics Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants