Unify blob store compress setting#39346
Merged
henningandersen merged 3 commits intoelastic:masterfrom Feb 28, 2019
Merged
Conversation
Blob store compression was all implemented generally, except reading the setting for it. Moved the setting to BlobStoreRepository to unify this. Also removed deprecated env setting 'repositories.fs.compress'. This is a follow up on elastic#39073
Collaborator
|
Pinging @elastic/es-distributed |
original-brownbear
approved these changes
Feb 25, 2019
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM :)
Not sure about adding something to the breaking changes (instinctively it may be a good idea, given the previous log message) => @ywelsch wdyt?
server/src/test/java/org/elasticsearch/repositories/blobstore/BlobStoreRepositoryTests.java
Show resolved
Hide resolved
ywelsch
approved these changes
Feb 25, 2019
Added breaking changes documentation on the removed 'repositories.fs.compress' setting. This is a follow up on elastic#39073
Contributor
Author
|
I added the breaking changes documentation for the removed setting. |
ywelsch
approved these changes
Feb 27, 2019
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
original-brownbear
added a commit
that referenced
this pull request
Apr 1, 2019
* Thanks to #39346 we can simplify the logic here some more, now that compress is a `final` field
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Thanks to elastic#39346 we can simplify the logic here some more, now that compress is a `final` field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blob store compression was all implemented generally, except reading the
setting for it. Moved the setting to BlobStoreRepository to unify this.
Also removed deprecated env setting 'repositories.fs.compress'.
This is a follow up on #39073
Given this is not documented, does this need to be included in the breaking changes
documentation for 8.0?