Simplify BlobStoreRepository Constructor#40653
Merged
original-brownbear merged 2 commits intoelastic:masterfrom Apr 1, 2019
original-brownbear:simplify-blobstore-ctor
Merged
Simplify BlobStoreRepository Constructor#40653original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:simplify-blobstore-ctor
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:simplify-blobstore-ctor
Conversation
* Thanks to #39346 we can simplify the logic here some more, now that compress is a `final` field
Collaborator
|
Pinging @elastic/es-distributed |
henningandersen
approved these changes
Apr 1, 2019
Contributor
henningandersen
left a comment
There was a problem hiding this comment.
LGTM.
Thanks @original-brownbear
Contributor
Author
|
thanks for reviewing @henningandersen! |
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
* Thanks to elastic#39346 we can simplify the logic here some more, now that compress is a `final` field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
finalfield