Blob store compression fix#39073
Merged
henningandersen merged 1 commit intoelastic:masterfrom Feb 20, 2019
Merged
Conversation
Blob store compression was not enabled for some of the files in snapshots due to constructor accessing sub-class fields, fixed to instead accept compress field as constructor param. Also fixed chunk size validation to work. Deprecated repositories.fs.compress setting as well to unify.
Collaborator
|
Pinging @elastic/es-distributed |
original-brownbear
approved these changes
Feb 19, 2019
Contributor
original-brownbear
left a comment
There was a problem hiding this comment.
LGTM, thanks @henningandersen
henningandersen
added a commit
that referenced
this pull request
Feb 20, 2019
Blob store compression was not enabled for some of the files in snapshots due to constructor accessing sub-class fields. Fixed to instead accept compress field as constructor param. Also fixed chunk size validation to work. Deprecated repositories.fs.compress setting as well to be able to unify in a future commit.
henningandersen
added a commit
that referenced
this pull request
Feb 20, 2019
Blob store compression was not enabled for some of the files in snapshots due to constructor accessing sub-class fields. Fixed to instead accept compress field as constructor param. Also fixed chunk size validation to work. Deprecated repositories.fs.compress setting as well to be able to unify in a future commit.
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Feb 25, 2019
Blob store compression was all implemented generally, except reading the setting for it. Moved the setting to BlobStoreRepository to unify this. Also removed deprecated env setting 'repositories.fs.compress'. This is a follow up on elastic#39073
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Feb 27, 2019
Added breaking changes documentation on the removed 'repositories.fs.compress' setting. This is a follow up on elastic#39073
henningandersen
added a commit
that referenced
this pull request
Feb 28, 2019
Blob store compression was all implemented generally, except reading the setting for it. Moved the setting to BlobStoreRepository to unify this. Also removed deprecated env setting 'repositories.fs.compress'. This is a follow up on #39073
80 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blob store compression was not enabled for some of the files in
snapshots due to constructor accessing sub-class fields, fixed to
instead accept compress field as constructor param. Also fixed chunk
size validation to work.
Deprecated repositories.fs.compress setting as well to unify.
This will be backported to 7.0 too and the repositories.fs.compress option will be removed in a follow up PR.