SQL: Fix edge case: <field> IN (null)#34802
Merged
matriv merged 7 commits intoelastic:masterfrom Oct 25, 2018
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search-aggs |
Contributor
Author
|
Depends on #34812 |
<field> IN(null)
d931ed9 to
99f5698
Compare
Handle the case when `null` is the only value in the list so that it's translated to a `MatchNoDocsQuery`. Followup to: elastic#34750
99f5698 to
c5c5cfd
Compare
<field> IN(null)<field> IN (null)
Contributor
Author
astefan
approved these changes
Oct 24, 2018
Contributor
astefan
left a comment
There was a problem hiding this comment.
LGTM. Just one picky comment.
|
|
||
| @Override | ||
| public Boolean fold() { | ||
| if (value.dataType() == DataType.NULL || list.size() == 1 && list.get(0).dataType() == DataType.NULL) { |
Contributor
There was a problem hiding this comment.
Better readability if additional brackets are used? if (value.dataType() == DataType.NULL || (list.size() == 1 && list.get(0).dataType() == DataType.NULL))
| if (values.isEmpty()) { | ||
| this.values = Collections.emptySet(); | ||
| } else { | ||
| this.values = new LinkedHashSet<>(Foldables.valuesOf(values, values.get(0).dataType())); |
Contributor
There was a problem hiding this comment.
I'm assuming that here all the values in values are of the same type otherwise we would have had the error message about different types.
Contributor
Author
|
retest this please |
matriv
pushed a commit
that referenced
this pull request
Oct 25, 2018
Handle the case when `null` is the only value in the list so that it's translated to a `MatchNoDocsQuery`. Followup to: #34750
Contributor
Author
|
Backported to |
matriv
pushed a commit
that referenced
this pull request
Oct 25, 2018
Handle the case when `null` is the only value in the list so that it's translated to a `MatchNoDocsQuery`. Followup to: #34750
Contributor
Author
|
Backported to |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 26, 2018
* master: (74 commits) XContent: Check for bad parsers (elastic#34561) Docs: Align prose with snippet (elastic#34839) document the search context is freed if the scroll is not extended (elastic#34739) Test: Lookup node versions on rest test start (elastic#34657) SQL: Return error with ORDER BY on non-grouped. (elastic#34855) Reduce channels in AbstractSimpleTransportTestCase (elastic#34863) [DOCS] Updates Elasticsearch monitoring tasks (elastic#34339) Check self references in metric agg after last doc collection (elastic#33593) (elastic#34001) [Docs] Add `indices.query.bool.max_clause_count` setting (elastic#34779) Add 6.6.0 version to master (elastic#34847) Test: ensure char[] doesn't being with prefix (elastic#34816) Remove static import from HLRC doc snippet (elastic#34834) Logging: server: clean up logging (elastic#34593) Logging: tests: clean up logging (elastic#34606) SQL: Fix edge case: `<field> IN (null)` (elastic#34802) [Test] Mute FullClusterRestartIT.testShrink() until test is fixed SQL: Introduce ODBC mode, similar to JDBC (elastic#34825) SQL: handle X-Pack or X-Pack SQL not being available in a more graceful way (elastic#34736) [Docs] Add explanation for code snippets line width (elastic#34796) CCR: Rename follow-task parameters and stats (elastic#34836) ...
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Handle the case when `null` is the only value in the list so that it's translated to a `MatchNoDocsQuery`. Followup to: #34750
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle the case when
nullis the only value in the list so thatit's translated to a
MatchNoDocsQuery.Followup to: #34750