Skip to content

SQL: Fix queries with filter resulting in NO_MATCH#34812

Merged
matriv merged 1 commit intoelastic:masterfrom
matriv:mt/fix-34613
Oct 24, 2018
Merged

SQL: Fix queries with filter resulting in NO_MATCH#34812
matriv merged 1 commit intoelastic:masterfrom
matriv:mt/fix-34613

Conversation

@matriv
Copy link
Copy Markdown
Contributor

@matriv matriv commented Oct 24, 2018

Previously, Mapper was returning an incorrect plan which resulted in an

SQLFeatureNotSupportedException: Found 1 problem(s)
line 1:8: Unexecutable item

Queries with a WHERE and/or HAVING clause which results in NO_MATCH
are now handled correctly and return 0 rows.

Fixes: #34613

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-aggs

Previously, `Mapper` was returning an incorrect plan which resulted in an
```
SQLFeatureNotSupportedException: Found 1 problem(s)
line 1:8: Unexecutable item
```

Queries with a `WHERE` and/or `HAVING` clause which results in NO_MATCH
are now handled correctly and return 0 rows.

Fixes: elastic#34613

Co-authored-by: Costin Leau <costin.leau@gmail.com>
Copy link
Copy Markdown
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matriv matriv merged commit 98cd7ca into elastic:master Oct 24, 2018
@matriv matriv deleted the mt/fix-34613 branch October 24, 2018 18:36
matriv pushed a commit that referenced this pull request Oct 24, 2018
Previously, `Mapper` was returning an incorrect plan which resulted in an
```
SQLFeatureNotSupportedException: Found 1 problem(s)
line 1:8: Unexecutable item
```

Queries with a `WHERE` and/or `HAVING` clause which results in NO_MATCH
are now handled correctly and return 0 rows.

Fixes: #34613

Co-authored-by: Costin Leau <costin.leau@gmail.com>
@matriv
Copy link
Copy Markdown
Contributor Author

matriv commented Oct 24, 2018

Backported to 6.x with f04f19e

kcm pushed a commit that referenced this pull request Oct 30, 2018
Previously, `Mapper` was returning an incorrect plan which resulted in an
```
SQLFeatureNotSupportedException: Found 1 problem(s)
line 1:8: Unexecutable item
```

Queries with a `WHERE` and/or `HAVING` clause which results in NO_MATCH
are now handled correctly and return 0 rows.

Fixes: #34613

Co-authored-by: Costin Leau <costin.leau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants