document the search context is freed if the scroll is not extended#34739
Merged
nik9000 merged 2 commits intoelastic:6.4from Oct 25, 2018
Merged
document the search context is freed if the scroll is not extended#34739nik9000 merged 2 commits intoelastic:6.4from
nik9000 merged 2 commits intoelastic:6.4from
Conversation
The `fetchPhaseShouldFreeContext` returns true when there is a scroll context but the scroll parameter is null, thus freeing the search context. https://github.com/elastic/elasticsearch/blob/183c32d4c39948e037a7fb44dccf31ab0d60d3c3/server/src/main/java/org/elasticsearch/search/SearchService.java#L491
Collaborator
|
Pinging @elastic/es-search-aggs |
nik9000
reviewed
Oct 25, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
Could you change the wording a little? I'm worried it won't be clear to someone who hasn't read the code.
| process all data -- it just needs to be long enough to process the previous | ||
| batch of results. Each `scroll` request (with the `scroll` parameter) sets a | ||
| new expiry time. | ||
| new expiry time. If the `scroll` parameter is not passed, then the next |
Member
There was a problem hiding this comment.
If a scroll request doesn't pass in scroll then we'll free the scroll context as part of that scroll request. The words you use makes it seem like the next scroll request would free the context.
nik9000
approved these changes
Oct 25, 2018
Member
nik9000
left a comment
There was a problem hiding this comment.
LGTM. I'll stick this in my "to merge" queue and pick it up soon.
nik9000
pushed a commit
that referenced
this pull request
Oct 25, 2018
…34739) The `fetchPhaseShouldFreeContext` returns true when there is a scroll context but the scroll parameter is null, thus freeing the search context. https://github.com/elastic/elasticsearch/blob/183c32d4c39948e037a7fb44dccf31ab0d60d3c3/server/src/main/java/org/elasticsearch/search/SearchService.java#L491
nik9000
pushed a commit
that referenced
this pull request
Oct 25, 2018
…34739) The `fetchPhaseShouldFreeContext` returns true when there is a scroll context but the scroll parameter is null, thus freeing the search context. https://github.com/elastic/elasticsearch/blob/183c32d4c39948e037a7fb44dccf31ab0d60d3c3/server/src/main/java/org/elasticsearch/search/SearchService.java#L491
Member
|
Merged and forward ported to the 6.5, 6.x, and master branches. You should see the documentation update in a half hour or so. |
Member
|
Thanks so much for making the doc clearer @scampi! |
nik9000
pushed a commit
that referenced
this pull request
Oct 25, 2018
…34739) The `fetchPhaseShouldFreeContext` returns true when there is a scroll context but the scroll parameter is null, thus freeing the search context. https://github.com/elastic/elasticsearch/blob/183c32d4c39948e037a7fb44dccf31ab0d60d3c3/server/src/main/java/org/elasticsearch/search/SearchService.java#L491
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 26, 2018
* master: (74 commits) XContent: Check for bad parsers (elastic#34561) Docs: Align prose with snippet (elastic#34839) document the search context is freed if the scroll is not extended (elastic#34739) Test: Lookup node versions on rest test start (elastic#34657) SQL: Return error with ORDER BY on non-grouped. (elastic#34855) Reduce channels in AbstractSimpleTransportTestCase (elastic#34863) [DOCS] Updates Elasticsearch monitoring tasks (elastic#34339) Check self references in metric agg after last doc collection (elastic#33593) (elastic#34001) [Docs] Add `indices.query.bool.max_clause_count` setting (elastic#34779) Add 6.6.0 version to master (elastic#34847) Test: ensure char[] doesn't being with prefix (elastic#34816) Remove static import from HLRC doc snippet (elastic#34834) Logging: server: clean up logging (elastic#34593) Logging: tests: clean up logging (elastic#34606) SQL: Fix edge case: `<field> IN (null)` (elastic#34802) [Test] Mute FullClusterRestartIT.testShrink() until test is fixed SQL: Introduce ODBC mode, similar to JDBC (elastic#34825) SQL: handle X-Pack or X-Pack SQL not being available in a more graceful way (elastic#34736) [Docs] Add explanation for code snippets line width (elastic#34796) CCR: Rename follow-task parameters and stats (elastic#34836) ...
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
…34739) The `fetchPhaseShouldFreeContext` returns true when there is a scroll context but the scroll parameter is null, thus freeing the search context. https://github.com/elastic/elasticsearch/blob/183c32d4c39948e037a7fb44dccf31ab0d60d3c3/server/src/main/java/org/elasticsearch/search/SearchService.java#L491
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
fetchPhaseShouldFreeContextreturns true when there is a scroll context but the scroll parameter is null, thus freeing the search context.elasticsearch/server/src/main/java/org/elasticsearch/search/SearchService.java
Line 491 in 183c32d