[CCR] Move ccr tests in core module back to ccr module#33711
Merged
[CCR] Move ccr tests in core module back to ccr module#33711
Conversation
When developing ccr it is not ideal if tests are in multiple modules. Even the classes these tests test are in the core module, it is easier if these tests are in ccr module in order to avoid running the test task in core module. This results in running many non ccr tests. This way when developing ccr we can run locally: ./gradlew x-pack:plugin:core:precommit x-pack:plugin:ccr:check before pushing to PR branches and be confident that the PR build passes, without running x-pack:plugin:core:check task.
Collaborator
|
Pinging @elastic/es-distributed |
jasontedor
approved these changes
Sep 14, 2018
Member
jasontedor
left a comment
There was a problem hiding this comment.
LGTM; thank you, Thank You, and THANK YOU! 🙏
martijnvg
added a commit
that referenced
this pull request
Sep 14, 2018
When developing ccr it is not ideal if tests are in multiple modules. Even the classes these tests test are in the core module, it is easier if these tests are in ccr module in order to avoid running the test task in core module. This results in running many non ccr tests. This way when developing ccr we can run locally: ./gradlew x-pack:plugin:core:precommit x-pack:plugin:ccr:check before pushing to PR branches and be confident that the PR build passes, without running x-pack:plugin:core:check task.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 14, 2018
* master: Add script to cache dependencies (elastic#33726) [DOCS] Moves security reference to docs folder (elastic#33643) Cleanup assertions in global checkpoint listeners (elastic#33722) [CCR] Move ccr tests in core module back to ccr module (elastic#33711) HLRC: ML PUT Calendar (elastic#33362) [Tests] Fix randomization in StringTermsIT (elastic#33678) Pin TLS1.2 in SSLConfigurationReloaderTests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When developing ccr it is not ideal if tests are in multiple modules.
Even the classes these tests test are in the core module, it is easier
if these tests are in ccr module in order to avoid running the test task
in core module. This results in running many non ccr tests.
This way when developing ccr we can run locally:
./gradlew x-pack:plugin:core:precommit x-pack:plugin:ccr:check
before pushing to PR branches and be confident that the PR build passes,
without running x-pack:plugin:core:check task.