Conversation
|
Pinging @elastic/es-core-infra |
|
Pinging @elastic/ml-core |
696b67e to
50ba8aa
Compare
|
retest this please |
benwtrent
left a comment
There was a problem hiding this comment.
Some minor things and consistencies.
There was a problem hiding this comment.
I would think that the this.jobIds should be made immutable here, or at least create a new ArrayList from the passed in list.
There was a problem hiding this comment.
For consistency, please use obj == null || getClass() != obj.getClass() for equality check.
There was a problem hiding this comment.
See comment on the Calender#equals method.
There was a problem hiding this comment.
This should be true. This is just a wrapper for the Calendar class whose parser ignores unknown fields.
There was a problem hiding this comment.
Why is this java-rest-high-snapshot... ?
There was a problem hiding this comment.
Good catch. I based this on another doc which in turn must have been copied form the snapshot restore API. There were a a number of ML docs that had the same mis-naming
a3d49b5 to
c8ff4ec
Compare
c8ff4ec to
647b817
Compare
* master: Add script to cache dependencies (elastic#33726) [DOCS] Moves security reference to docs folder (elastic#33643) Cleanup assertions in global checkpoint listeners (elastic#33722) [CCR] Move ccr tests in core module back to ccr module (elastic#33711) HLRC: ML PUT Calendar (elastic#33362) [Tests] Fix randomization in StringTermsIT (elastic#33678) Pin TLS1.2 in SSLConfigurationReloaderTests
For #29827