[Tests] Fix randomization in StringTermsIT#33678
Merged
cbuescher merged 1 commit intoelastic:masterfrom Sep 14, 2018
Merged
Conversation
I just ran into this while removing multi-line statements, but this seems like an actual bug in the intended randomization of the test, possibly a leftover from a debugging session. My guess is the COLLECT_SEGMENT_ORDS variable should be randomized.
Collaborator
|
Pinging @elastic/es-search-aggs |
Member
Author
|
@jpountz could you confirm my guess here is right, since you last seem to have touched that area? |
cbuescher
pushed a commit
that referenced
this pull request
Sep 14, 2018
It looks like the COLLECT_SEGMENT_ORDS flag should be randomized.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 14, 2018
* master: Add script to cache dependencies (elastic#33726) [DOCS] Moves security reference to docs folder (elastic#33643) Cleanup assertions in global checkpoint listeners (elastic#33722) [CCR] Move ccr tests in core module back to ccr module (elastic#33711) HLRC: ML PUT Calendar (elastic#33362) [Tests] Fix randomization in StringTermsIT (elastic#33678) Pin TLS1.2 in SSLConfigurationReloaderTests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just ran into this while removing multi-line statements, but this seems like
an actual bug in the intended randomization of the test, possibly a leftover
from a debugging session. My guess is the COLLECT_SEGMENT_ORDS variable should
be randomized.