Improves snapshot logging and snapshot deletion error handling#25264
Merged
abeyad merged 2 commits intoelastic:masterfrom Jun 15, 2017
Merged
Improves snapshot logging and snapshot deletion error handling#25264abeyad merged 2 commits intoelastic:masterfrom
abeyad merged 2 commits intoelastic:masterfrom
Conversation
This commit does two things: 1. Adds logging at the DEBUG level for when the index-N blob is updated. 2. When attempting to delete a snapshot, if the snapshot was not found in the repository data, an exception is now thrown instead of silently ignoring the lack of presence of the snapshot in the repository data.
imotov
approved these changes
Jun 15, 2017
Contributor
imotov
left a comment
There was a problem hiding this comment.
Left a small suggestion. Otherwise LGTM.
| .filter(id -> !snapshotId.equals(id)) | ||
| .collect(Collectors.toMap(SnapshotId::getUUID, Function.identity())); | ||
| if (newSnapshotIds.size() == snapshotIds.size()) { | ||
| throw new ElasticsearchException("Attempting to remove non-existent snapshot [{}] from repository data", snapshotId); |
Contributor
There was a problem hiding this comment.
Perhaps, something like ResourceNotFoundException would be more appropriate here?
Author
|
thanks for the review @imotov |
abeyad
pushed a commit
that referenced
this pull request
Jun 15, 2017
This commit does two things: 1. Adds logging at the DEBUG level for when the index-N blob is updated. 2. When attempting to delete a snapshot, if the snapshot was not found in the repository data, an exception is now thrown instead of silently ignoring the lack of presence of the snapshot in the repository data.
abeyad
pushed a commit
that referenced
this pull request
Jun 15, 2017
This commit does two things: 1. Adds logging at the DEBUG level for when the index-N blob is updated. 2. When attempting to delete a snapshot, if the snapshot was not found in the repository data, an exception is now thrown instead of silently ignoring the lack of presence of the snapshot in the repository data.
abeyad
pushed a commit
that referenced
this pull request
Jun 16, 2017
This commit does two things: 1. Adds logging at the DEBUG level for when the index-N blob is updated. 2. When attempting to delete a snapshot, if the snapshot was not found in the repository data, an exception is now thrown instead of silently ignoring the lack of presence of the snapshot in the repository data.
Author
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 16, 2017
…y-context * 'master' of github.com:elastic/elasticsearch: (21 commits) [DOCS] Clarify expected availability of HDFS for the HDFS Repository (elastic#25220) Remove some redundant 140 character checkstyle suppressions [Docs] more fix for the parent-join docs [Docs] Fix cross reference for parent-join field More advices around search speed and disk usage. (elastic#25252) Add documentation for the new parent-join field (elastic#25227) [analysis-icu] Allow setting unicodeSetFilter (elastic#20814) Introduce translog size and age based retention policies (elastic#25147) Add needs methods for specific variables to Painless script context factories. (elastic#25267) Improves snapshot logging and snapshoth deletion error handling (elastic#25264) Add unit test for PathHierarchyTokenizerFactory (elastic#24984) Deprecate tribe service Moved more token filters to analysis-common module. [Test] Make sure that SearchAfterSortedDocQueryTests uses a single threaded searcher [DOCS] Defined es-test-dir and plugins-examples-dir in index.asciidoc. (elastic#25232) Test fix - removed superfluous assertion (elastic#25247) [Test] restore BWC for parent-join now that the new mapping format is in 5.x Add a section named "relations" in the ParentJoinFieldMapper (elastic#25248) test: Ported more OldIndexBackwardsCompatibilityIT tests to full cluster restart qa tests. (elastic#25173) fix: Sort Processor does not have proper behavior with targetField (elastic#25237) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit does two things:
updated.
in the repository data, an exception is now thrown instead of silently
ignoring the lack of presence of the snapshot in the repository data.