[DOCS] Defined es-test-dir in index.asciidoc. #25232
Merged
debadair merged 2 commits intoelastic:masterfrom Jun 15, 2017
Merged
[DOCS] Defined es-test-dir in index.asciidoc. #25232debadair merged 2 commits intoelastic:masterfrom
debadair merged 2 commits intoelastic:masterfrom
Conversation
… specifying the location of included tests.
nik9000
approved these changes
Jun 14, 2017
Member
nik9000
left a comment
There was a problem hiding this comment.
Fine by me. I'd probably call it test-resources. I don't think es needs to be in the name because these resources are only for the docs not the rest of ES.
Contributor
|
When I added that variable in the index*.asciidoc files in https://github.com/elastic/x-pack-elasticsearch/pull/1722 it reduced the errors, however I still get the following: |
lcawl
approved these changes
Jun 14, 2017
Contributor
Author
|
@nik9000 Since we're entering the brave new world of cross-repo doc builds, I'm going to leave the |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jun 16, 2017
…y-context * 'master' of github.com:elastic/elasticsearch: (21 commits) [DOCS] Clarify expected availability of HDFS for the HDFS Repository (elastic#25220) Remove some redundant 140 character checkstyle suppressions [Docs] more fix for the parent-join docs [Docs] Fix cross reference for parent-join field More advices around search speed and disk usage. (elastic#25252) Add documentation for the new parent-join field (elastic#25227) [analysis-icu] Allow setting unicodeSetFilter (elastic#20814) Introduce translog size and age based retention policies (elastic#25147) Add needs methods for specific variables to Painless script context factories. (elastic#25267) Improves snapshot logging and snapshoth deletion error handling (elastic#25264) Add unit test for PathHierarchyTokenizerFactory (elastic#24984) Deprecate tribe service Moved more token filters to analysis-common module. [Test] Make sure that SearchAfterSortedDocQueryTests uses a single threaded searcher [DOCS] Defined es-test-dir and plugins-examples-dir in index.asciidoc. (elastic#25232) Test fix - removed superfluous assertion (elastic#25247) [Test] restore BWC for parent-join now that the new mapping format is in 5.x Add a section named "relations" in the ParentJoinFieldMapper (elastic#25248) test: Ported more OldIndexBackwardsCompatibilityIT tests to full cluster restart qa tests. (elastic#25173) fix: Sort Processor does not have proper behavior with targetField (elastic#25237) ...
Contributor
|
Based on my tests this needs to be cherry-picked to 5.4, 5.5, and 5.x |
lcawl
pushed a commit
to lcawl/elasticsearch
that referenced
this pull request
Jun 20, 2017
elastic#25232) Use these attributes when specifying the location of included tests.
Contributor
|
I cherry-picked into 5.x successfully |
lcawl
pushed a commit
that referenced
this pull request
Jun 20, 2017
#25232) Use these attributes when specifying the location of included tests.
Contributor
|
Ditto for 5.5 |
lcawl
pushed a commit
that referenced
this pull request
Jun 20, 2017
#25232) Use these attributes when specifying the location of included tests.
Contributor
|
Ditto for 5.4. No further cherry-picking required as far as I can see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use this attribute when specifying the location of included tests.
I also updated the existing test paths.
@nik9000 added you as a reviewer since you're the only one who's using test includes so far. Mostly just want you to know I'm adding the attribute.