[analysis-icu] Allow setting unicodeSetFilter#20814
Conversation
628976a to
f7a2d24
Compare
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
This should remain without a closing tag. Javadocs use html 4, and actually expect there to be only the opening paragraph tag. See http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#format.
f7a2d24 to
2ce7f96
Compare
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@rjernst thanks for the ping (completely forgot about this one too). |
jpountz
left a comment
There was a problem hiding this comment.
This PR looks good to me. I left a minor comment, would you mind fixing it?
There was a problem hiding this comment.
please remove trailing ";"
|
@elasticmachine please test it |
UnicodeSetFilter was only allowed in the icu_folding token filter. It seems useful to expose this setting in icu_normalizer token filter and char filter.
2ce7f96 to
3ffeabc
Compare
|
@jpountz thanks for the review, I amended the patch. |
|
Great, thanks! @elasticmachine please test it |
UnicodeSetFilter was only allowed in the icu_folding token filter. It seems useful to expose this setting in icu_normalizer token filter and char filter.
…y-context * 'master' of github.com:elastic/elasticsearch: (21 commits) [DOCS] Clarify expected availability of HDFS for the HDFS Repository (elastic#25220) Remove some redundant 140 character checkstyle suppressions [Docs] more fix for the parent-join docs [Docs] Fix cross reference for parent-join field More advices around search speed and disk usage. (elastic#25252) Add documentation for the new parent-join field (elastic#25227) [analysis-icu] Allow setting unicodeSetFilter (elastic#20814) Introduce translog size and age based retention policies (elastic#25147) Add needs methods for specific variables to Painless script context factories. (elastic#25267) Improves snapshot logging and snapshoth deletion error handling (elastic#25264) Add unit test for PathHierarchyTokenizerFactory (elastic#24984) Deprecate tribe service Moved more token filters to analysis-common module. [Test] Make sure that SearchAfterSortedDocQueryTests uses a single threaded searcher [DOCS] Defined es-test-dir and plugins-examples-dir in index.asciidoc. (elastic#25232) Test fix - removed superfluous assertion (elastic#25247) [Test] restore BWC for parent-join now that the new mapping format is in 5.x Add a section named "relations" in the ParentJoinFieldMapper (elastic#25248) test: Ported more OldIndexBackwardsCompatibilityIT tests to full cluster restart qa tests. (elastic#25173) fix: Sort Processor does not have proper behavior with targetField (elastic#25237) ...
UnicodeSetFilter was only allowed in the icu_folding token filter.
It seems useful to expose this setting in icu_normalizer token filter and char filter.
Closes #20820