Fix serialization of NodeGpuStatsResponse when no GPU is present#142937
Merged
ChrisHegarty merged 4 commits intoelastic:mainfrom Feb 24, 2026
Merged
Fix serialization of NodeGpuStatsResponse when no GPU is present#142937ChrisHegarty merged 4 commits intoelastic:mainfrom
ChrisHegarty merged 4 commits intoelastic:mainfrom
Conversation
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
mayya-sharipova
approved these changes
Feb 24, 2026
Contributor
|
+1 for new changes as well |
mayya-sharipova
approved these changes
Feb 24, 2026
benwtrent
approved these changes
Feb 24, 2026
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Feb 24, 2026
…on-sliced-reindex * upstream/main: Activity logging improvements (elastic#142901) Fix serialization of NodeGpuStatsResponse when no GPU is present (elastic#142937) Add doc on master elections in DistributedArchitectureGuide (elastic#142435) ESQL: Account for missing StubRelation due to SurrogateExpressions replacement (elastic#142882) Add BulkByScrollTask Serialization Tests (elastic#142697) Rebalance CI test partitions to reduce Part3 bottleneck (elastic#142930) Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlClientYamlIT test {p0=esql/40_tsdb/to_aggregate_metric_double with multi_values} elastic#142964 Bump OpenTelemetry dependencies (elastic#142323) SQL: add support for API key to JDBC and CLI (elastic#142021) Ensure requested capability exists (elastic#142695) Warn and fall back to local branches.json (elastic#142606) [CI] Mute testWithFetchFailures, testAddCompletionListenerScheduleErr… (elastic#142926) ESQL: Add support for ORC file format (elastic#142900) Update wolfi (versioned) (elastic#142948) Add BulkByScrollResponse Serialization Tests (elastic#142688) Run 25_id_generation with and without synthetic id (elastic#142770)
mayya-sharipova
pushed a commit
to mayya-sharipova/elasticsearch
that referenced
this pull request
Feb 24, 2026
…stic#142937) NodeGpuStatsResponse uses writeVLong for totalGpuMemoryInBytes, which throws IllegalStateException on the sentinel value -1 returned by GPUSupport.getTotalGpuMemory() when no compatible GPU is available. The fix is to replace -1 with 0L (which does not change the semantics), and add a serialization round-trip test that reproduces the original failure and validates fix. resolves elastic#142936
elasticsearchmachine
pushed a commit
that referenced
this pull request
Feb 24, 2026
…2937) (#142991) NodeGpuStatsResponse uses writeVLong for totalGpuMemoryInBytes, which throws IllegalStateException on the sentinel value -1 returned by GPUSupport.getTotalGpuMemory() when no compatible GPU is available. The fix is to replace -1 with 0L (which does not change the semantics), and add a serialization round-trip test that reproduces the original failure and validates fix. resolves #142936 Co-authored-by: Chris Hegarty <62058229+ChrisHegarty@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeGpuStatsResponseuseswriteVLongfortotalGpuMemoryInBytes, which throws IllegalStateException on the sentinel value-1returned byGPUSupport.getTotalGpuMemory()when no compatible GPU is available. The fix is to replace-1with0L(which does not change the semantics), and add a serialization round-trip test that reproduces the original failure and validates fix.No transport version change is needed since the serial-form is not in any shipping release.
resolves #142936