Add BulkByScrollResponse Serialization Tests#142688
Add BulkByScrollResponse Serialization Tests#142688joshua-adams-1 merged 3 commits intoelastic:mainfrom
Conversation
Adds BulkByScrollResponseWireSerializingTests and removes a redundant testRoundTrip() test from BulkByScrollResponseTests
| private boolean includeCreated; | ||
| private boolean testExceptions = randomBoolean(); | ||
|
|
||
| public void testRountTrip() throws IOException { |
There was a problem hiding this comment.
There is greater serialisation test coverage from BulkByScrollResponseserializationTests than this test previously provided
|
Pinging @elastic/es-distributed (Team:Distributed) |
PeteGillinElastic
left a comment
There was a problem hiding this comment.
I confess that I'm a little doubtful about the utility of this test. It seems to me that the most common cause of regressions in the wire serialization code is someone adding a new field and forgetting to update the serialization. But if they've forgotten that, they're definitely not going to remember to update this test, which will continue to pass.
The only alternative to that would be to do something reflection-based, which seems overkill (and is, I assume, not something that we're doing elsewhere).
Still, it's probably going to do more good than harm, so LGTM.
I think this would only be true if someone added a new field but didn't change the What this test will catch in future is:
etc, which is much better coverage than before. Plus it tests equality and hashcode, which the original |
Adds BulkByScrollResponseWireSerializingTests and removes a redundant testRoundTrip() test from BulkByScrollResponseTests
…on-sliced-reindex * upstream/main: Activity logging improvements (elastic#142901) Fix serialization of NodeGpuStatsResponse when no GPU is present (elastic#142937) Add doc on master elections in DistributedArchitectureGuide (elastic#142435) ESQL: Account for missing StubRelation due to SurrogateExpressions replacement (elastic#142882) Add BulkByScrollTask Serialization Tests (elastic#142697) Rebalance CI test partitions to reduce Part3 bottleneck (elastic#142930) Mute org.elasticsearch.xpack.esql.qa.multi_node.EsqlClientYamlIT test {p0=esql/40_tsdb/to_aggregate_metric_double with multi_values} elastic#142964 Bump OpenTelemetry dependencies (elastic#142323) SQL: add support for API key to JDBC and CLI (elastic#142021) Ensure requested capability exists (elastic#142695) Warn and fall back to local branches.json (elastic#142606) [CI] Mute testWithFetchFailures, testAddCompletionListenerScheduleErr… (elastic#142926) ESQL: Add support for ORC file format (elastic#142900) Update wolfi (versioned) (elastic#142948) Add BulkByScrollResponse Serialization Tests (elastic#142688) Run 25_id_generation with and without synthetic id (elastic#142770)
Adds
BulkByScrollResponseWireSerializingTestsand removes a redundanttestRoundTrip()test fromBulkByScrollResponseTests