[8.x] Make semantic text part of the text family (#119792)#119962
Merged
Mikep86 merged 3 commits intoelastic:8.xfrom Jan 13, 2025
Merged
[8.x] Make semantic text part of the text family (#119792)#119962Mikep86 merged 3 commits intoelastic:8.xfrom
Mikep86 merged 3 commits intoelastic:8.xfrom
Conversation
Co-authored-by: Ioana Tagirta <ioana.tagirta@elastic.co> (cherry picked from commit 29e1bf9) # Conflicts: # x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java # x-pack/plugin/esql/qa/testFixtures/src/main/resources/semantic_text.csv-spec
Mikep86
commented
Jan 10, 2025
...ugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java
Show resolved
Hide resolved
Mikep86
commented
Jan 10, 2025
Comment on lines
+135
to
+164
| grok | ||
| required_capability: semantic_text_field_caps | ||
|
|
||
| FROM semantic_text METADATA _id | ||
| | GROK st_logs """%{TIMESTAMP_ISO8601:date} %{IP:ip} %{EMAILADDRESS:email} %{NUMBER:num}""" | ||
| | KEEP st_logs, date, ip, email, num | ||
| | SORT st_logs | ||
| ; | ||
|
|
||
| st_logs:text | date:keyword | ip:keyword | email:keyword | num:keyword | ||
| 2023-01-23T12:15:00.000Z 127.0.0.1 some.email@foo.com 42 | 2023-01-23T12:15:00.000Z | 127.0.0.1 | some.email@foo.com | 42 | ||
| 2024-01-23T12:15:00.000Z 1.2.3.4 foo@example.com 42 | 2024-01-23T12:15:00.000Z | 1.2.3.4 | foo@example.com | 42 | ||
| 2024-12-23T12:15:00.000Z 1.2.3.4 example@example.com 4553 | 2024-12-23T12:15:00.000Z | 1.2.3.4 | example@example.com | 4553 | ||
| ; | ||
|
|
||
| dissect | ||
| required_capability: semantic_text_field_caps | ||
|
|
||
| FROM semantic_text METADATA _id | ||
| | DISSECT st_logs """%{date} %{ip} %{email} %{num}""" | ||
| | KEEP st_logs, date, ip, email, num | ||
| | SORT st_logs | ||
| ; | ||
|
|
||
| st_logs:text | date:keyword | ip:keyword | email:keyword | num:keyword | ||
| 2023-01-23T12:15:00.000Z 127.0.0.1 some.email@foo.com 42 | 2023-01-23T12:15:00.000Z | 127.0.0.1 | some.email@foo.com | 42 | ||
| 2024-01-23T12:15:00.000Z 1.2.3.4 foo@example.com 42 | 2024-01-23T12:15:00.000Z | 1.2.3.4 | foo@example.com | 42 | ||
| 2024-12-23T12:15:00.000Z 1.2.3.4 example@example.com 4553 | 2024-12-23T12:15:00.000Z | 1.2.3.4 | example@example.com | 4553 | ||
| ; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
These tests were pulled in from main, should we keep them?
Member
There was a problem hiding this comment.
They're not part of 8.x - I'll let @ioanatia call this one out
Member
There was a problem hiding this comment.
They are missing because the auto backport failed for #117337 - I looked at the PR and I think we should only include the tests. This PR made changes that assumed we will have a semantic_text field type in ES|QL and this is no longer the case. The tests would be good to keep, we can validate that commands like GROK or DISSECT will continue to work with fields mapped as semantic_text.
Member
carlosdelest
left a comment
There was a problem hiding this comment.
Can we include the changes from #119940, and add the test-release label to double check we're not causing trouble for CSV tests?
Contributor
Author
|
buildkite test this |
carlosdelest
approved these changes
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation