Ignore CSV tests that require field caps change#119940
Merged
ioanatia merged 1 commit intoelastic:mainfrom Jan 10, 2025
Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
approved these changes
Jan 10, 2025
Contributor
alex-spies
left a comment
There was a problem hiding this comment.
LGTM, thanks for looking into it quickly!
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
Member
Author
|
tests are not muted on 8.x - but I still need to backport the CsvTests change 🤦♀️ EDIT: actually #119792 needs to be backported first |
Mikep86
pushed a commit
to Mikep86/elasticsearch
that referenced
this pull request
Jan 10, 2025
Contributor
|
This change was backported in #119962 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#119918
semantic_textfields are now reported astextby the field caps which results in failures for CSV tests for non snapshot builds.This is a quirk of CSV tests that I will need to fix, single-node and multi-node tests should still run the semantic text tests.
From what I tested locally the single and multi node tests should be succesful.
Since this seems to be more of a test problem and not an indicative of a prod bug, the goal is to enable the CSV test suite for now.